Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3304] FE - Add a drop down to select running application on start process component #5702

Merged
merged 7 commits into from May 27, 2020

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ACA-3304

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

❗ No coverage uploaded for pull request head (dev-siva-ACA-3304-add-applications-drop-down@86d7e8e). Click here to learn what that means.
The diff coverage is n/a.

lib/process-services/src/lib/i18n/en.json Outdated Show resolved Hide resolved
<mat-form-field *ngIf="showSelectApplicationDropdown" [floatLabel]="'always'" class="adf-start-process-app-list">
<mat-select
placeholder="{{'ADF_PROCESS_LIST.START_PROCESS.FORM.LABEL.APPLICATIONS' | translate}}"
(selectionChange)="onAppSelectionChange($event)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we established a rule not to use this format (onSomething) some time ago. I remember @mauriziovitale was changing all the occurrences of this format to something else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the rule is applicable for the class properties
onSomething: new EventEmitter<any>(),
TO
something: new EventEmitter<any>(),

The catch block should have on as prefix (something)="onSomething($event)". Correct me if am i wrong

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #5702 into develop will increase coverage by 0.55%.
The diff coverage is 73.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5702      +/-   ##
===========================================
+ Coverage    83.80%   84.36%   +0.55%     
===========================================
  Files          943      193     -750     
  Lines        26712     7048   -19664     
  Branches      3753     1000    -2753     
===========================================
- Hits         22386     5946   -16440     
+ Misses        3208      794    -2414     
+ Partials      1118      308     -810     
Impacted Files Coverage Δ
...process-list/components/start-process.component.ts 78.97% <72.58%> (-6.46%) ⬇️
...cess-services/src/lib/form/start-form.component.ts 66.66% <100.00%> (+1.04%) ⬆️
...rc/lib/version-manager/version-upload.component.ts
lib/core/settings/host-settings.module.ts
lib/insights/src/lib/mock/index.ts
...ervices/src/lib/breadcrumb/breadcrumb.component.ts
...rd-view-arrayitem/card-view-arrayitem.component.ts
lib/core/directives/directive.module.ts
...form/components/widgets/core/content-link.model.ts
... and 744 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b8e99...61ce40c. Read the comment docs.

@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3304-add-applications-drop-down branch 3 times, most recently from ff3ee8f to 23f019b Compare May 25, 2020 08:20
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3304-add-applications-drop-down branch from 23f019b to 0d40b1e Compare May 26, 2020 17:10
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3304-add-applications-drop-down branch from 3fddd48 to 61ce40c Compare May 27, 2020 08:17
@mauriziovitale mauriziovitale merged commit 0f5fd35 into develop May 27, 2020
@mauriziovitale mauriziovitale deleted the dev-siva-ACA-3304-add-applications-drop-down branch May 27, 2020 11:23
@pr-triage pr-triage bot added the PR: merged label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants