New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACA-3304] FE - Add a drop down to select running application on start process component #5702
[ACA-3304] FE - Add a drop down to select running application on start process component #5702
Conversation
cf8cb9b
to
b386219
Compare
b386219
to
ea6ee2a
Compare
Codecov Report
|
0dbf239
to
86d7e8e
Compare
lib/process-services/src/lib/process-list/components/start-process.component.ts
Outdated
Show resolved
Hide resolved
<mat-form-field *ngIf="showSelectApplicationDropdown" [floatLabel]="'always'" class="adf-start-process-app-list"> | ||
<mat-select | ||
placeholder="{{'ADF_PROCESS_LIST.START_PROCESS.FORM.LABEL.APPLICATIONS' | translate}}" | ||
(selectionChange)="onAppSelectionChange($event)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we established a rule not to use this format (onSomething) some time ago. I remember @mauriziovitale was changing all the occurrences of this format to something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the rule is applicable for the class properties
onSomething: new EventEmitter<any>()
,
TO
something: new EventEmitter<any>()
,
The catch block should have on
as prefix (something)="onSomething($event)". Correct me if am i wrong
lib/process-services/src/lib/process-list/components/start-process.component.html
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/process-list/components/start-process.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/process-list/components/start-process.component.spec.ts
Outdated
Show resolved
Hide resolved
86d7e8e
to
1c590a0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5702 +/- ##
===========================================
+ Coverage 83.80% 84.36% +0.55%
===========================================
Files 943 193 -750
Lines 26712 7048 -19664
Branches 3753 1000 -2753
===========================================
- Hits 22386 5946 -16440
+ Misses 3208 794 -2414
+ Partials 1118 308 -810 Continue to review full report at Codecov.
|
ff3ee8f
to
23f019b
Compare
…t process component
23f019b
to
0d40b1e
Compare
3fddd48
to
61ce40c
Compare
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3304
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: