Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3209]Fix e2e about attach file from local #5944

Merged
merged 6 commits into from Aug 4, 2020

Conversation

cristinaj
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #5944 into develop will increase coverage by 2.62%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5944      +/-   ##
===========================================
+ Coverage    75.53%   78.16%   +2.62%     
===========================================
  Files          701      142     -559     
  Lines        14847     3920   -10927     
  Branches      2911      780    -2131     
===========================================
- Hits         11215     3064    -8151     
+ Misses        2775      603    -2172     
+ Partials       857      253     -604     
Impacted Files Coverage Δ
lib/core/mock/identity-user.service.mock.ts
...d-view/components/card-view/card-view.component.ts
...ns/diagram-icon-alfresco-publish-task.component.ts
...ces-cloud/src/lib/pipes/process-name-cloud.pipe.ts
...rocess/start-process/start-process-cloud.module.ts
...s-services/src/lib/app-list/apps-list.component.ts
lib/core/utils/moment-date-formats.model.ts
lib/core/directives/highlight.directive.ts
...ghts/src/lib/mock/diagram/diagram-boundary.mock.ts
...lib/process/directives/process-directive.module.ts
... and 833 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dec2ba...e3371cd. Read the comment docs.

@@ -55,7 +55,7 @@ describe('Process Task - Attach content file', () => {
const processDefinitionName = browser.params.resources.ACTIVITI_CLOUD_APPS.SIMPLE_APP.processes.uploadSingleMultipleFiles;
const uploadWidgetId = browser.params.resources.ACTIVITI_CLOUD_APPS.SIMPLE_APP.forms.uploadSingleMultiple.widgets.contentMultipleAttachFileId;
const taskName = browser.params.resources.ACTIVITI_CLOUD_APPS.SIMPLE_APP.tasks.uploadSingleMultipleFiles;
const folderName = StringUtil.generateRandomString(5);
const folderName = '0' + StringUtil.generateRandomString(5);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have this 0 at the beginning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test uses hruser and there are a lot of folders created[by other people, other tests, i don't know]. attachFileFromContentNode() method is checking if the content[folder in this case] is displayed, without taking in consideration to click on 'Show more' in case is displayed. So if the folder is not displayed in the first ones, the test will fail. The easiest way for me was to fix it like this. Other options would be to use a new created user instead of hruser or modify the attachFileFromContentNode() method to take in consideration cases where multiple folders are created.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is better to use a clean user

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems i can't use clean user without changing the process definition. The user task has hruser as assignee. We can raise separate ticket for this.

@DenysVuika DenysVuika merged commit 732a34f into develop Aug 4, 2020
@DenysVuika DenysVuika deleted the dev-crisj-AAE-3209 branch August 4, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants