Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3209]Fix e2e about attach file from local #5944

Merged
merged 6 commits into from Aug 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -70,24 +70,24 @@ describe('Process Task - Attach content file', () => {
'location': browser.params.resources.Files.ADF_DOCUMENTS.PDF_B.file_path
};

beforeAll(async () => {
beforeAll(async (done) => {
await apiService.login(browser.params.testConfig.hrUser.email, browser.params.testConfig.hrUser.password);

const processDefinition = await processDefinitionService.getProcessDefinitionByName(processDefinitionName, simpleApp);
processInstance = await processInstancesService.createProcessInstance(processDefinition.entry.key, simpleApp, { name: 'upload process' });
await apiService.getInstance().login(browser.params.testConfig.hrUser.email, browser.params.testConfig.hrUser.password);
uploadedFolder = await uploadActions.createFolder(folderName, '-my-');
await uploadActions.uploadFile(pdfFileOne.location, pdfFileOne.name, uploadedFolder.entry.id);
await uploadActions.uploadFile(pdfFileTwo.location, pdfFileTwo.name, uploadedFolder.entry.id);
});

afterAll(async () => {
await uploadActions.deleteFileOrFolder(uploadedFolder.entry.id);
});

beforeEach(async () => {
await loginSSOPage.login(browser.params.testConfig.hrUser.email, browser.params.testConfig.hrUser.password);
await navigationBarPage.navigateToProcessServicesCloudPage();
await appListCloudComponent.checkApsContainer();
done();
});

afterAll(async () => {
await uploadActions.deleteFileOrFolder(uploadedFolder.entry.id);
});

it('[C311290] Should be able to attach multiple files when widget allows multiple files to be attached from content', async () => {
Expand Down
4 changes: 2 additions & 2 deletions e2e/process-services-cloud/start-task-form-cloud.e2e.ts
Expand Up @@ -304,8 +304,8 @@ describe('Start Task Form', () => {
await taskFormCloudComponent.clickClaimButton();

const localFileWidget = await widget.attachFileWidgetCloud('Attachlocalfile');
await browser.sleep(5000);
await localFileWidget.attachLocalFile(pdfFile.location);
await localFileWidget.clickAttachContentFile('Attachlocalfile');
await contentNodeSelectorDialogPage.attachFileFromLocal(pdfFile.name, pdfFile.location);
await localFileWidget.checkFileIsAttached(pdfFile.name);
await localFileWidget.removeFile(pdfFile.name);
await localFileWidget.checkFileIsNotAttached(pdfFile.name);
Expand Down
4 changes: 1 addition & 3 deletions e2e/protractor.excludes.json
Expand Up @@ -4,8 +4,6 @@
"C362240": "Include once ADF starts using ACS 7 , https://issues.alfresco.com/jira/browse/ADF-5182",
"C362241": "Include once ADF starts using ACS 7, https://issues.alfresco.com/jira/browse/ADF-5182",
"C362242": "Include once ADF starts using ACS 7, https://issues.alfresco.com/jira/browse/ADF-5182",
"C362265": "Include once ADF starts using ACS 7, https://issues.alfresco.com/jira/browse/ADF-5182",
"C310358": "Include once process storage services removed, https://issues.alfresco.com/jira/browse/AAE-3177",
"C311290": "Include once process storage services removed, https://issues.alfresco.com/jira/browse/AAE-3177"
"C362265": "Include once ADF starts using ACS 7, https://issues.alfresco.com/jira/browse/ADF-5182"
}

Expand Up @@ -15,7 +15,8 @@
* limitations under the License.
*/

import { by, element } from 'protractor';
import { by, element, browser } from 'protractor';
import * as remote from 'selenium-webdriver/remote';
import { DocumentListPage } from '../pages/document-list.page';
import { BrowserVisibility } from '../../core/utils/browser-visibility';
import { BrowserActions } from '../../core/utils/browser-actions';
Expand Down Expand Up @@ -129,6 +130,23 @@ export class ContentNodeSelectorDialogPage {
await this.clickMoveCopyButton();
}

async attachFileFromLocal(fileName: string, fileLocation: string): Promise<void> {
await this.checkDialogIsDisplayed();

await browser.setFileDetector(new remote.FileDetector());
const uploadButton = element(by.css('adf-upload-button input'));
await BrowserVisibility.waitUntilElementIsPresent(uploadButton);
await uploadButton.sendKeys(fileLocation);

await this.dataTable.waitForTableBody();
await this.dataTable.waitTillContentLoaded();
await this.dataTable.checkRowContentIsDisplayed(fileName);

await this.clickContentNodeSelectorResult(fileName);
await this.checkCopyMoveButtonIsEnabled();
await this.clickMoveCopyButton();
}

async searchAndSelectResult(searchText: string, name: string) {
await this.typeIntoNodeSelectorSearchField(searchText);
try {
Expand Down
2 changes: 1 addition & 1 deletion lib/testing/src/lib/core/pages/info-drawer.page.ts
Expand Up @@ -65,7 +65,7 @@ export class InfoDrawerPage {
}
}

async getNoOfTabs(): Promise<Number> {
async getNoOfTabs(): Promise<number> {
return this.tabsPage.getNoOfTabs();
}

Expand Down
Expand Up @@ -38,6 +38,7 @@ export class AttachFileWidgetCloudPage {
const uploadButton = element(by.css('adf-upload-button input'));
await BrowserVisibility.waitUntilElementIsPresent(uploadButton);
await uploadButton.sendKeys(fileLocation);
await BrowserActions.click(uploadButton);
await BrowserVisibility.waitUntilElementIsPresent(uploadButton);
}

Expand Down