Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5374]Fix flaky filters tests #6894

Merged
merged 8 commits into from
Apr 6, 2021
Merged

[ADF-5374]Fix flaky filters tests #6894

merged 8 commits into from
Apr 6, 2021

Conversation

cristinaj
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Apr 2, 2021

Codecov Report

Merging #6894 (187cf9b) into develop (37b10ec) will increase coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6894      +/-   ##
===========================================
+ Coverage    76.51%   77.63%   +1.11%     
===========================================
  Files          885      156     -729     
  Lines        20219     4341   -15878     
  Branches      4030      855    -3175     
===========================================
- Hits         15471     3370   -12101     
+ Misses        3509      679    -2830     
+ Partials      1239      292     -947     
Impacted Files Coverage Δ
lib/core/form/components/widgets/core/tab.model.ts
...ices-cloud/src/lib/process/process-cloud.module.ts
...nents/raphael/icons/raphael-icon-mule.component.ts
...task-list/validators/task-description.validator.ts
.../core/card-view/models/card-view-baseitem.model.ts
...omponents/widgets/core/form-outcome-event.model.ts
lib/core/blank-page/blank-page.module.ts
...ts/gateways/diagram-exclusive-gateway.component.ts
...viewer/components/viewer-more-actions.component.ts
...ocess-filters/models/process-filter-cloud.model.ts
... and 719 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b10ec...187cf9b. Read the comment docs.

@eromano eromano merged commit cdaad8e into develop Apr 6, 2021
@eromano eromano deleted the dev-crisj-ADF-5374 branch April 6, 2021 13:36
TomikaArome pushed a commit that referenced this pull request Apr 9, 2021
* Check Travis

* Try with sleep

* Add more sleep and logs

* no message

* Fix

* no message

* no message

* Remove sleep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants