Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-5929] Open datatable actions menu on enter #8868

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[ACS-5929] Open datatable actions menu on enter #8868

merged 1 commit into from
Sep 5, 2023

Conversation

MichalKinas
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

Actions menu trigger button doesn't open menu on enter. https://alfresco.atlassian.net/browse/ACS-5929

What is the new behaviour?

Actions menu trigger opens menu on enter.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MichalKinas MichalKinas merged commit bd518b6 into develop Sep 5, 2023
36 checks passed
@MichalKinas MichalKinas deleted the bugfix/dev-mkinas-ACS-5929-accessibility-control-centre-user-menu-view-edit-not-accessible branch September 5, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnil-verma-gl swapnil-verma-gl swapnil-verma-gl approved these changes

@MateuszHY MateuszHY MateuszHY approved these changes

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@g-jaskowski g-jaskowski g-jaskowski approved these changes

@nikita-web-ua nikita-web-ua Awaiting requested review from nikita-web-ua

@dominikiwanekhyland dominikiwanekhyland Awaiting requested review from dominikiwanekhyland

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

Assignees
No one assigned
Labels
A/N BDU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MichalKinas @swapnil-verma-gl @MateuszHY @AleksanderSklorz @g-jaskowski