Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless protractor tests #8998

Merged
merged 4 commits into from
Oct 16, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@ import { createApiService,
SettingsPage,
StringUtil,
UploadActions,
UserModel,
UsersActions,
ViewerPage
} from '@alfresco/adf-testing';
import { FileModel } from '../../models/ACS/file.model';
import { NodeEntry } from '@alfresco/js-api';

describe('SSO in ADF using ACS and AIS, Download Directive, Viewer, DocumentList, implicitFlow true', () => {

Expand All @@ -54,7 +56,11 @@ describe('SSO in ADF using ACS and AIS, Download Directive, Viewer, DocumentList
location: browser.params.resources.Files.ADF_DOCUMENTS.PNG.file_path
});

let pdfUploadedFile; let pngUploadedFile; let folder; let acsUser;
let pdfUploadedFile: NodeEntry;
let pngUploadedFile: NodeEntry;
let folder: NodeEntry;
let acsUser: UserModel
;
DenysVuika marked this conversation as resolved.
Show resolved Hide resolved
const folderName = StringUtil.generateRandomString(5);

beforeAll(async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ describe('Document List Component', () => {
});

describe('Custom Column', () => {
let folderName;
let folderName: string;

const pdfFileModel = new FileModel({
name: browser.params.resources.Files.ADF_DOCUMENTS.PDF.file_name,
location: browser.params.resources.Files.ADF_DOCUMENTS.PDF.file_path
Expand Down
30 changes: 0 additions & 30 deletions e2e/core/infinite-scrolling.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,36 +86,6 @@ describe('Enable infinite scrolling', () => {
await contentServicesPage.contentList.dataTablePage().waitTillContentLoaded();
});

it('[C260484] Should be possible to enable infinite scrolling', async () => {
await contentServicesPage.openFolder(folderModel.name);
await contentServicesPage.enableInfiniteScrolling();
await infinitePaginationPage.clickLoadMoreButton();
await contentServicesPage.contentList.dataTablePage().waitTillContentLoadedInfinitePagination();

for (let i = 0; i < nrOfFiles; i++) {
await contentServicesPage.checkContentIsDisplayed(fileNames[i]);
}
});

it('[C268165] Delete folder when infinite scrolling is enabled', async () => {
await contentServicesPage.openFolder(deleteUploaded.entry.name);
await contentServicesPage.enableInfiniteScrolling();
await infinitePaginationPage.clickLoadMoreButton();
await contentServicesPage.contentList.dataTablePage().waitTillContentLoadedInfinitePagination();

for (let i = 0; i < nrOfDeletedFiles; i++) {
await contentServicesPage.checkContentIsDisplayed(deleteFileNames[i]);
}
await expect(await contentServicesPage.getDocumentList().dataTablePage().numberOfRows()).toEqual(nrOfDeletedFiles);

await contentServicesPage.deleteContent(deleteFileNames[nrOfDeletedFiles - 1]);
await contentServicesPage.checkContentIsNotDisplayed(deleteFileNames[nrOfDeletedFiles - 1]);

for (let i = 0; i < nrOfDeletedFiles - 1; i++) {
await contentServicesPage.checkContentIsDisplayed(deleteFileNames[i]);
}
});

it('[C299201] Should use default pagination settings for infinite pagination', async () => {
await contentServicesPage.openFolder(folderModel.name);

Expand Down
6 changes: 3 additions & 3 deletions e2e/core/pages/content-services.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ export class ContentServicesPage {
siteListDropdown = new DropdownPage($(`mat-select[data-automation-id='site-my-files-option']`));
sortingDropdown = new DropdownPage($('mat-select[data-automation-id="grid-view-sorting"]'));

async pressContextMenuActionNamed(actionName): Promise<void> {
async pressContextMenuActionNamed(actionName: string): Promise<void> {
await BrowserActions.clickExecuteScript(`button[data-automation-id="context-${actionName}"]`);
}

async isContextActionEnabled(actionName): Promise<boolean> {
async isContextActionEnabled(actionName: string): Promise<boolean> {
const actionButton = $(`button[data-automation-id="context-${actionName}"`);
await BrowserVisibility.waitUntilElementIsVisible(actionButton);
return actionButton.isEnabled();
Expand Down Expand Up @@ -239,7 +239,7 @@ export class ContentServicesPage {
await this.contentList.doubleClickRow(nodeName);
}

async selectRow(nodeName): Promise<void> {
async selectRow(nodeName: string): Promise<void> {
await this.contentList.selectRow(nodeName);
}

Expand Down
104 changes: 0 additions & 104 deletions e2e/core/viewer/file-extensions/viewer-archive.component.e2e.ts

This file was deleted.

134 changes: 0 additions & 134 deletions e2e/core/viewer/file-extensions/viewer-component.e2e.ts

This file was deleted.

Loading