Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless protractor tests #8998

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Remove useless protractor tests #8998

merged 4 commits into from
Oct 16, 2023

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Oct 15, 2023 •
edited

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • remove useless Viewer tests (clicking the content and waiting for dialog does not test anything)
  • remove demo-shell specific tests that have no connection to reality

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@DenysVuika DenysVuika merged commit 4621662 into develop Oct 16, 2023
5 checks passed
@DenysVuika DenysVuika deleted the remove-useless-protractor-tests branch October 16, 2023 09:44
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnil-verma-gl swapnil-verma-gl swapnil-verma-gl approved these changes

@MichalKinas MichalKinas MichalKinas approved these changes

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DenysVuika @swapnil-verma-gl @MichalKinas @AleksanderSklorz