ACS-8254 [ADF] Add functionality to pass data on confirmation in DialogComponent #9845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaryaBalvanovich
force-pushed
the
ACS-8254-add-functionality-to-pass-data-onconfirmation-in-dialogComponent
branch
from
bf490b2
to
4cc4b25
Compare
DaryaBalvanovich
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
DaryaBalvanovich
requested review from
tomson7777,
MichalKinas and
AleksanderSklorz
MichalKinas
reviewed
Jun 21, 2024
| @@ -89,9 +89,12 @@ function openDialog() { | |||
| title: 'Dialog title', | |||
| contentComponent: ExampleDialogComponent, | |||
| componentData: { nodeId: 'nodeId', name: 'node name' } // any data can be passed | |||
| dataOnConfirm$: of({ nodeId, data: {} }) | |||
There was a problem hiding this comment.
Okay so what is the use case for this change?
There was a problem hiding this comment.
if you click confirm button and need to pass any data to after close action. So this is the case when we call dialog in effects and want to do something with data we can pass it in component or service and get in effects
MichalKinas
approved these changes
Jun 21, 2024
tamaragruszka
approved these changes
Jun 21, 2024
jacekpluta
approved these changes
Jun 21, 2024
DaryaBalvanovich
force-pushed
the
ACS-8254-add-functionality-to-pass-data-onconfirmation-in-dialogComponent
branch
from
6286013
to
591489a
Compare
|
dominikiwanekhyland
approved these changes
Jun 21, 2024
DenysVuika
approved these changes
Jun 21, 2024
DenysVuika
deleted the
ACS-8254-add-functionality-to-pass-data-onconfirmation-in-dialogComponent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
https://hyland.atlassian.net/browse/ACS-8254
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
can't pass data on confirmation
dataOnConfirm$What is the new behaviour?
Able to pass data on confirmation with
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: