Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinSet nomenclature #215

Closed
epatters opened this issue Jul 24, 2020 · 0 comments · Fixed by #217
Closed

FinSet nomenclature #215

epatters opened this issue Jul 24, 2020 · 0 comments · Fixed by #217
Assignees
Labels

Comments

@epatters
Copy link
Member

epatters commented Jul 24, 2020

Like @olynch, I'm not thrilled by our use of FinOrd for the skeleton of FinSet. This usage appears occasionally but it's not widespread and is easily confused with another category whose morphisms are monotone functions. As an alternative, I suggest using a parameterized type

struct FinSet{T}
  set::T
end

We could then use FinSet{Int} instead of FinOrd, and use FinSet{Set} or similar for the category FinSet itself. Similarly, we would have FinRel{Int} instead of the unpleasant FinOrdRel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant