-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setproctitle module in required #3
Conversation
try: | ||
from setproctitle import setproctitle | ||
except ImportError as err: | ||
setproctitle = lambda s: None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would raise a proper Error exception instead of letting it crash. So that there is no "big" behavior difference
This PR should only have The others "blank" changes (space / TAB) should be in a separate PR if you want to clean that kind of spaces / tabs .. otherwise +1 ;) Also : yes, I think we can keep the |
@ddurieux : ping ? |
Commit have to be squashed IMO |
yep, squash that, rebase it on develop, and it'll be merged ;) |
Keep the try
…o master+setproctitle
this can be closed per #67 |
No description provided.