Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup coverage #41

Merged
merged 2 commits into from
Jun 2, 2015
Merged

Setup coverage #41

merged 2 commits into from
Jun 2, 2015

Conversation

gst
Copy link
Contributor

@gst gst commented Jun 1, 2015

should give us, (once the coveralls.io workers will process it), a coveralls.io badge with some %, not unknown.

@gst
Copy link
Contributor Author

gst commented Jun 1, 2015

should give us, (once the coveralls.io workers will process it), a coveralls.io badge with some %, not unknown.

only once another commit will be added after this PR is merged..

@@ -20,4 +20,4 @@ script:
- sh test/test_shebang.sh
# specific call to launch coverage data into coveralls.io
after_success:
coveralls
mv test/.coverage && coveralls --rcfile=test/.coveragerc -v
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mv test/.coverage ? You don't have forgotten something in the command? :p

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna correct that but have to sync a bit with the mess of previous evening.. ;)

@Seb-Solon
Copy link
Contributor

Commit are all mix now because you push -f on develop yesterday night gst (cf travis build triggered)

Why such a push on devel that lead to that messy PR (importedlib mixed with changelog and coverall)

@gst
Copy link
Contributor Author

gst commented Jun 2, 2015

Commit are all mix now because you push -f on develop yesterday night gst (cf travis build triggered)

YOU did it :D cfr : the events notification history in gitter-alignak room , @ 22:07 (montréal time) yesterday !!

Why such a push on devel that lead to that messy PR (importedlib mixed with changelog and coverall)

I'm outrageous ;)

@Seb-Solon
Copy link
Contributor

+1 mea culpa. I just looked at the commiter, no clue in Travis of who pushed that.
I was kinda supried we pushed on alignak at the same time actually :D

@gst
Copy link
Contributor Author

gst commented Jun 2, 2015

there we go, @ddurieux it's corrected, I think you can merge ;)

ddurieux pushed a commit that referenced this pull request Jun 2, 2015
@ddurieux ddurieux merged commit 923ef8e into Alignak-monitoring:develop Jun 2, 2015
@gst gst deleted the setup_coverage branch June 2, 2015 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants