[WIP] Travis enh: fix coverage mess with test_bad_start #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gst
force-pushed
the
fix_test_prob_coverage
branch
from
b2c60f7
to
5db2049
Compare
gst
changed the title
gst
changed the title
|
don't merge already.. |
gst
changed the title
gst
changed the title
gst
force-pushed
the
fix_test_prob_coverage
branch
from
cdc40c2
to
cebc380
Compare
Actually the http_daemon thread was ran as a "daemon-thread" : once sys.exit() is called the thread is also exited. but depending on the conditions the sys.exit() may NOT be called, or not directly, leading to delayed / longer time for the daemon to exit. It's better to pro-actively check our "interrupted" flag by/in this thread itself. Also make sure to join the childs/clients threads at the end of the http_thread.
gst
force-pushed
the
fix_test_prob_coverage
branch
2 times, most recently
from
55c72eb
to
b8ca4b3
Compare
added 2 commits
June 3, 2015 17:21
more a workaround for now. we should effectively "simply" join the http_daemon thread(s).
so to shutdown annoying prob during coverage :
test_port_not_free (test_bad_start.Test_Scheduler_Bad_Start) ... ok
Coverage.py warning: No data was collected.
Traceback (most recent call last):
File "/opt/python/2.6.9/lib/python2.6/multiprocessing/util.py", line 235, in _run_finalizers
finalizer()
File "/opt/python/2.6.9/lib/python2.6/multiprocessing/util.py", line 174, in __call__
res = self._callback(*self._args, **self._kwargs)
File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/cov_core.py", line 20, in multiprocessing_finish
cov.save()
File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/coverage/control.py", line 493, in save
self.data.write(suffix=data_suffix)
File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/coverage/data.py", line 91, in write
self.write_file(filename)
File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/coverage/data.py", line 131, in write_file
fdata = open(filename, 'wb')
IOError: [Errno 2] No such file or directory: '/tmp/tmpOumlg1/.coverage.testing-worker-linux-027f0490-2-7771-linux-4-50667445.3028.493619'
gst
force-pushed
the
fix_test_prob_coverage
branch
from
b8ca4b3
to
640fd31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so to shutdown an annoying prob during coverage :
test_port_not_free (test_bad_start.Test_Scheduler_Bad_Start) ... ok
Coverage.py warning: No data was collected.
Traceback (most recent call last):
File "/opt/python/2.6.9/lib/python2.6/multiprocessing/util.py", line 235, in _run_finalizers
finalizer()
File "/opt/python/2.6.9/lib/python2.6/multiprocessing/util.py", line 174, in call
res = self._callback(_self._args, *_self._kwargs)
File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/cov_core.py", line 20, in multiprocessing_finish
cov.save()
File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/coverage/control.py", line 493, in save
self.data.write(suffix=data_suffix)
File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/coverage/data.py", line 91, in write
self.write_file(filename)
File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/coverage/data.py", line 131, in write_file
fdata = open(filename, 'wb')
IOError: [Errno 2] No such file or directory: '/tmp/tmpOumlg1/.coverage.testing-worker-linux-027f0490-2-7771-linux-4-50667445.3028.493619'