Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Travis enh: fix coverage mess with test_bad_start #45

Closed
wants to merge 3 commits into from
Closed

[WIP] Travis enh: fix coverage mess with test_bad_start #45

wants to merge 3 commits into from

Commits on Jun 3, 2015

  1. Enh: http_daemon: Check interrupted flag in own listening thread 

    Actually the http_daemon thread was ran as a "daemon-thread" :
once sys.exit() is called the thread is also exited.

but depending on the conditions the sys.exit() may NOT be called, or not directly,
leading to delayed / longer time for the daemon to exit.

It's better to pro-actively check our "interrupted" flag by/in this thread itself.

Also make sure to join the childs/clients threads at the end of the http_thread.
    Grégory Starck committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    111922c View commit details
    Browse the repository at this point in the history

  2. Enh: give some time to http_daemon thread to cleanly exit 

    more a workaround for now.

we should effectively "simply" join the http_daemon thread(s).
    Grégory Starck committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    6c431df View commit details
    Browse the repository at this point in the history

  3. Travis help: explicitely require cov-core==1.15.0 

    so to shutdown annoying prob during coverage :

test_port_not_free (test_bad_start.Test_Scheduler_Bad_Start) ... ok
Coverage.py warning: No data was collected.
Traceback (most recent call last):
  File "/opt/python/2.6.9/lib/python2.6/multiprocessing/util.py", line 235, in _run_finalizers
    finalizer()
  File "/opt/python/2.6.9/lib/python2.6/multiprocessing/util.py", line 174, in __call__
    res = self._callback(*self._args, **self._kwargs)
  File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/cov_core.py", line 20, in multiprocessing_finish
    cov.save()
  File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/coverage/control.py", line 493, in save
    self.data.write(suffix=data_suffix)
  File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/coverage/data.py", line 91, in write
    self.write_file(filename)
  File "/home/travis/virtualenv/python2.6.9/lib/python2.6/site-packages/coverage/data.py", line 131, in write_file
    fdata = open(filename, 'wb')
IOError: [Errno 2] No such file or directory: '/tmp/tmpOumlg1/.coverage.testing-worker-linux-027f0490-2-7771-linux-4-50667445.3028.493619'
    Grégory Starck committed Jun 3, 2015
    Configuration menu
    Copy the full SHA
    640fd31 View commit details
    Browse the repository at this point in the history