Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update team members pagination to be 1-indexed for 1.20 #43

Closed
shrik450 opened this issue Aug 10, 2023 · 2 comments
Closed

Update team members pagination to be 1-indexed for 1.20 #43

shrik450 opened this issue Aug 10, 2023 · 2 comments

Comments

@shrik450
Copy link
Collaborator

Currently, AllSpice Hub is at 1.19, where the team members endpoint is paginated with a 0-based index. This was fixed in 1.20 (go-gitea/gitea#24754) and the endpoing is 1-based as documented. Right now, py-allspice uses the 0-index, and when AllSpice Hub switches to 1.20 this will lead to duplicates in the list of team members. We'll have to change Team.get_members when we release 1.20.

@kdumontnu
Copy link
Contributor

Thanks for finding this! Can you add a cron job to schedule the CI tests nightly? I think it'll help us preemptively catch issues like this (where we might update the application to 1.20, but forget to update py-allspice).

@jtran
Copy link
Contributor

jtran commented Oct 27, 2023

Resolved by #48.

@jtran jtran closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants