-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider loading first scene by default in scene widget #34
Comments
This should be still the case. The logic I added checked if (n_scenes >1). On my machine testing with some LIF, CZI and TIFF I only get the selection widget (and the extra option widget) when s>1. |
oh! it's possible i was using a stale branch. lemme check again |
Here's the relevant code: napari-aicsimageio/napari_aicsimageio/core.py Lines 200 to 215 in 7605974
|
right, but after Untitled.movsample file: https://www.dropbox.com/s/w8bgza0g96swwza/dims_p4z5t3c2y32x32-tile2x3.nd2?dl=0 |
oh, sorry, I reread your comment. I think you might have misunderstood my goal here. I'm proposing to load scene0 by default when |
I'm ok with loading scene[0] automatically for multi-scene files, though for my use case I'd prefer this not to be the case (first few scenes are typically various staining controls I rarely want to analyze in napari). This could be an option perhaps? (Not sure the current checkbox approach is stored between sessions...) |
yeah, that's definitely the case, that's why I was saying in the first post "I found myself looking specifically for a file that didn't have scenes, so that I could at least have an image loaded". it's ok if you'd rather not have it load. just a thought. perhaps an option someday... but low priority |
Oh derp, I understood that that combined with the next sentence that the scene it didn't load. Sorry! |
current behavior is like bioformats in Fiji, where one has to do an additional step if scenes are detected... so there's certainly precedent for your preference! let's leave it as default, and if I care enough someday I'll make it configurable :) |
BTW: Is there some thought to napari providing/storing plugin preferences, so such behavior could be configured and stored between sessions? |
yep, will come with the new manifest as a "configuration" contribution here. Will roughly follow the vscode spec described here. In the meantime, plugins would have to do their own persistence. (magicgui helps with that sort of thing using the |
I tend to agree that we should just default to scene 0 on load. It would be great to have all the parameters persist and I would argue that we split this issue up into two issues / PRs. (This also helps down the line because I want to add parameters for "load lazy vs load in-memory" and having that parameter persist would be amazing.)
|
I love the new scene widget... but the other day I found myself looking specifically for a file that didn't have scenes, so that I could at least have an image loaded. What you you think about loading the first scene by default, in addition to showing the widget to select additional scenes? This keeps the image-loading process to "one step" for the relatively common use case of starting with scene0.
cc @psobolewskiPhD @JacksonMaxfield
The text was updated successfully, but these errors were encountered: