Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Handle prompt escape sequences #358

Closed
kinland opened this issue Feb 27, 2023 · 2 comments
Closed

[BUG] Handle prompt escape sequences #358

kinland opened this issue Feb 27, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@kinland
Copy link

kinland commented Feb 27, 2023

Describe the bug

The dev of zsh-autocomplete says that the issue is due to fzf-tab not parsing prompt escape sequences:

@dhorkin No, the problem is that Fzf Tab doesn't know how to parse the prompt escape sequences that are allowed in the completion system's format style. You should file a bug with Fzf Tab about this.

I can make sure:

  • [✅] I am using the latest version of fzf-tab
  • [✅] this is the minimal zshrc which can reproduce this bug
  • [✅] fzf-tab is loaded after compinit
  • [✅] fzf-tab is loaded after plugins which will wrap Tab, like junegunn/fzf/completion.zsh
  • [✅] fzf-tab is loaded before zsh-autosuggestions, zsh-syntax-highlighting and fast-syntax-highlighting.

To Reproduce

Steps to reproduce the behavior:

  1. Type 'git s'
  2. Press Tab
  3. Group legend has %{%} and the like in it

Expected behavior

Prompt escape sequences should be escaped properly and fzf-tab should display the same way regardless of whether zsh-autocomplete is being used

Screenshots

With fzf-tab enabled and zsh-autocomplete disabled:
image
With both enabled:
image

Environment:

  • OS: Ubuntu 22.04
  • zsh version: 5.8.1

Minimal zshrc

If applicable, add a minimal zshrc to help us analyze.
.zshrc:

source ${ZDOTDIR:-~}/.antidote/antidote.zsh
antidote load
[ -f ~/.fzf.zsh ] && source ~/.fzf.zsh
autoload -Uz compinit && compinit -i

.zsh_plugins.txt

skywind3000/z.lua
changyuheng/fz
marlonrichert/zsh-autocomplete

Log

No log appears when I hit CTRL+X

@kinland kinland added the bug Something isn't working label Feb 27, 2023
@Aloxaf
Copy link
Owner

Aloxaf commented Mar 19, 2023

This is a known issue: #24

@kinland
Copy link
Author

kinland commented Mar 19, 2023

That issue is closed as "completed." If the workaround is those zshrc lines, then that really should be in the readme.

@Aloxaf Aloxaf closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants