Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cauldron in the New Camp can be used without a scoop pt. 1 #212

Merged
merged 2 commits into from Apr 18, 2021
Merged

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Apr 17, 2021

Describe the bug
The cauldron near the ore heap in the New Camp can be used without having a Scoop in the inventory.

Expected behavior
The cauldron near the ore heap in the New Camp now correctly requires a scoop to use.

Additional context

  • This issue was split from #52. Part one of #213.
  • Closest waypoint: NC_HUT13_OUT
  • The useWithItem of the MOB should be ITMISCOOP
  • The sceme of the MOB is CAULDRON
  • Suggested short name: UseWithItemNCCauldron1

Screenhots
ScreenShot_2021_2_4_23_3_1

@szapp szapp added type: world bug compatibility: easy validation: validated provided fix impl: change obj var labels Mar 28, 2021
@szapp szapp added this to the v1.1.0 milestone Mar 28, 2021
@szapp szapp added this to To Do in v1.1.0 via automation Mar 28, 2021
@szapp szapp added this to VOB property in Fix templates Mar 28, 2021
@AmProsius AmProsius self-assigned this Mar 28, 2021
@szapp
Copy link
Collaborator Author

@szapp szapp commented Mar 28, 2021

Here is some instruction to find the exact coordinates of a VOB:

  • Start the spacer.exe in the System directory of Gothic. It may be necessary to remove the patch if starting does not succeed.
  • Load the entire world (world.zen) or world file corresponding to the world part in which the VOB resides. The files are located in \work\_Data\Worlds\_work. If there are no files extract them from \Data\worlds.vdf.
  • Find the VOB. Either by flying towards it or in the object list.
  • Open the Internals section of the object property window
  • Select the entry trafoOSToWSPos
  • Copy the three floating-point values in the bottom
  • These values can be used in conjunction with G1CP_FindVobByPosF(float x, float y, float z).

image

@szapp szapp self-assigned this Apr 16, 2021
szapp added a commit that referenced this issue Apr 17, 2021
@szapp szapp moved this from To Do to In Progress in v1.1.0 Apr 17, 2021
@szapp szapp requested a review from AmProsius Apr 17, 2021
AmProsius
AmProsius previously requested changes Apr 18, 2021
Copy link
Owner

@AmProsius AmProsius left a comment

The player character now gets a scoop if he didn't have one before and uses the cauldron.

@AmProsius AmProsius dismissed their stale review Apr 18, 2021

The player character gets the scoop with the test.

@AmProsius AmProsius merged commit 3e00235 into master Apr 18, 2021
v1.1.0 automation moved this from In Progress to Done Apr 18, 2021
@AmProsius AmProsius deleted the bug212 branch Apr 18, 2021
szapp added a commit that referenced this issue Apr 20, 2021
szapp added a commit that referenced this issue Jan 18, 2022
Finding VOBs by their exact position can now be further narrowed down by
their class. Like before only the first matching VOB will be found. The
function can now also detect light VOBs which where previously ignored.
For details, see the header commment of ent of 'G1CP_FindVobByPosPtr'.
Common class definitions are defined as constants in constants.d. All
affected fixes are updated.

Refs #46 #51 #52 #127 #212 #213 #226
szapp added a commit that referenced this issue Jan 19, 2022
Instead of specifying a class to narrow down the search (see previous
commit), the option is now more versatile: Now the last parameter is a
callback function. It can either be one of the existing class check
functions or a custom function to narrow down the search more flexibly
and potentially based on more or more complex checks.

Refs #46 #51 #52 #127 #212 #213 #226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy impl: change obj var provided fix type: world bug validation: validated
Projects
Fix templates
Change VOB property
v1.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants