Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

Add feature -> upload image from gallery #11

Closed
Aman-zishan opened this issue Oct 4, 2020 · 10 comments
Closed

Add feature -> upload image from gallery #11

Aman-zishan opened this issue Oct 4, 2020 · 10 comments
Assignees
Labels
difficulty: easy enhancement New feature or request good first issue Good for newcomers hacktoberfest celebrate opensource! help wanted Extra attention is needed new feature Add a new feature!

Comments

@Aman-zishan
Copy link
Owner

Right now the menu bar contains two pending functionalities #10 and #1 . It would be convenient for the users to upload image from gallery too.

@Aman-zishan Aman-zishan added enhancement New feature or request good first issue Good for newcomers hacktoberfest celebrate opensource! help wanted Extra attention is needed difficulty: easy labels Oct 4, 2020
@infiniteoverflow
Copy link

I would like to contribute this feature.

@Aman-zishan
Copy link
Owner Author

I would like to contribute this feature.

Good to hear that!. I would suggest you to add the gallery icon near the multiple photopicker icon. Assigning this to you.

@Aman-zishan Aman-zishan added the new feature Add a new feature! label Oct 4, 2020
@infiniteoverflow
Copy link

so you mean there will be two options towards the right : Multi-photo picker and gallery ?

@Aman-zishan
Copy link
Owner Author

so you mean there will be two options towards the right : Multi-photo picker and gallery ?

Yes, that would be better right. Or do you have anything else in your mind?

@infiniteoverflow
Copy link

but in that case it would become uneven , with 1 button on the left and 2 on the right. But if u feel this could be a good design , then fine with me :)

@Aman-zishan
Copy link
Owner Author

Aman-zishan commented Oct 4, 2020

but in that case it would become uneven , with 1 button on the left and 2 on the right. But if u feel this could be a good design , then fine with me :)

Yeah there appears an issue like that, so we could increase the bar height and add icon to the center. But doing that shouldnt affect the camera preview right, so we have to scale the camera preview responsive to that height.

@infiniteoverflow
Copy link

yeah , but it will affect screens with relatively smaller height... so it could become an issue

@infiniteoverflow
Copy link

I will try to go with the logic you had mentioned at the beginning. later we could change it accordingly

@Aman-zishan
Copy link
Owner Author

I will try to go with the logic you had mentioned at the beginning. later we could change it accordingly

Lets go like that then. cool!

@Aman-zishan
Copy link
Owner Author

Aman-zishan commented Oct 4, 2020

I will try to go with the logic you had mentioned at the beginning. later we could change it accordingly

Also it would be better if you could implement multi image picker package and give a functionality to change each pic to a single pdf if the user want more than one pic. If you already had this in mind well and good.

@Aman-zishan Aman-zishan changed the title Add function -> upload image from gallery Add feature -> upload image from gallery Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
difficulty: easy enhancement New feature or request good first issue Good for newcomers hacktoberfest celebrate opensource! help wanted Extra attention is needed new feature Add a new feature!
Projects
None yet
Development

No branches or pull requests

2 participants