Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payment spec: change price per impression (or any other event) dynamically (AIP#6) #16

Closed
Ivshti opened this issue Jan 4, 2019 · 3 comments
Assignees

Comments

@Ivshti
Copy link
Member

Ivshti commented Jan 4, 2019

advertisers should be able to dynamically change the price per impression; this could be done by having them submit a validator message to both validators, which will update their eventRecorders to address the change

the original payment spec should contain a thresholds: see pricingBounds here

this would require changing eventAggregator, eventReducer and the channel routes so that existing recorders can be updated dynamically

for details on the schema, see AIP#6


@samparsky start by going off the comment in the AIP that outlines the spec and PR-ing it to campaignSpec.md in adex-protocol

then, implement the date structures in Rust primitives and open a PR so we can review

Then proceed to implementing in the JS and Rust implementations, with comprehensive tests - unit tests for rule matching and integration test with a few compound rules matched together

@Ivshti Ivshti added this to the release-1 milestone Jan 4, 2019
@Ivshti Ivshti removed this from the release-1 milestone Feb 13, 2019
@Ivshti Ivshti added this to the release-2 milestone Mar 12, 2019
@Ivshti Ivshti changed the title payment spec: change price per impression dynamically payment spec: change price per impression (or any type of event) dynamically Mar 19, 2019
@Ivshti
Copy link
Member Author

Ivshti commented Jun 7, 2019

closing cause it's a dupe of #157 ; actually this one was obviously the older one, but the newer one is better described

@Ivshti
Copy link
Member Author

Ivshti commented Dec 13, 2019

Re-opened cause we need a new spec for this (AIP6)

@Ivshti Ivshti reopened this Dec 13, 2019
@Ivshti Ivshti modified the milestones: v2.0, v0.8 Mar 16, 2020
@Ivshti Ivshti changed the title payment spec: change price per impression (or any type of event) dynamically payment spec: change price per impression (or any type of event) dynamically: AIP#6 Mar 16, 2020
@Ivshti Ivshti changed the title payment spec: change price per impression (or any type of event) dynamically: AIP#6 payment spec: change price per impression (or any type of event) dynamically (AIP#6) Mar 16, 2020
@Ivshti Ivshti changed the title payment spec: change price per impression (or any type of event) dynamically (AIP#6) payment spec: change price per impression (or any other event) dynamically (AIP#6) Mar 16, 2020
@Ivshti
Copy link
Member Author

Ivshti commented May 10, 2020

closing, it was done by #272

@Ivshti Ivshti closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants