Add File based Storage toggle for Photos

[dvd741-a]

Add toggle env option to toggle between file based or S3 Bucket storage.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
reactive-resume-docs	⬜️ Ignored (Inspect)		Jun 18, 2022 at 0:21AM (UTC)

[lgtm-com]

This pull request introduces 1 alert when merging 1c5d025 into 2f6072a - view on LGTM.com

new alerts:

• 1 for Server crash

[dvd741-a]

@AmruthPillai - Can you have a look at this merge request ... ?

[AmruthPillai]

Quite an interesting solution, thank you for your contribution! :)

[AmruthPillai]

@dvd741-a Would you also be able to add the local file storage path to docker volumes, so that on every docker restart/reload, the uploaded images are not erased?

[dvd741-a]

@dvd741-a Would you also be able to add the local file storage path to docker volumes, so that on every docker restart/reload, the uploaded images are not erased?

I would be able to as soon as I can test it :-)
Wasn't able to build the docker image myself using the dockerfile in the repository. If a version gets bumped/built and put on dockerhub, I can try the correct path for the mount

[michael-robbins]

I believe inside the container /app/server/dist/assets/uploads is the path being referred to in this PR.

So adding something like: VOLUME /app/server/dist/assets/uploads inside server/Dockerfile should do the trick here!

Not sure about the future implications of doing this though, as if the codebase plans to add anything later into the uploads folder, because it's a VOLUME, that folder will not be updated with new files from the container once the user has created the volume on it's first run.

[dvd741-a]

@michael-robbins Can you have a look if this seems correct to you? / Not sure who can approve. - I've already mounted the path to a folder in my environment. As soon as a new version is built & gets put on dockerhub - It should start working. (Not sure if this happens automated @AmruthPillai ?)

[michael-robbins]

It looks fine to me! I've already updated my setup to use the new env vars as well as the volume!