Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate why WalkingLady glTF model does not load in Cesium #4722

Closed
pjcozzi opened this issue Dec 6, 2016 · 13 comments
Closed

Evaluate why WalkingLady glTF model does not load in Cesium #4722

pjcozzi opened this issue Dec 6, 2016 · 13 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 6, 2016

Is this an issue in Cesium or the sample model? KhronosGroup/glTF-Sample-Models#12

@lasalvavida can you please look at this after the 1.1 updates? Or anyone else in the meantime...

@pjcozzi pjcozzi added the good first issue An opportunity for first time contributors label Dec 14, 2016
@pjcozzi
Copy link
Contributor Author

pjcozzi commented Dec 14, 2016

Could be the same issue three.js had, mrdoob/three.js#10319.

@denverpierce
Copy link
Contributor

Looks exactly the same as the three.js bug (stuff of nightmares).

ss

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Dec 19, 2016

@denverpierce thanks for looking into it. Any chance you have the bandwidth to try out the same type of fix used in three?

@denverpierce
Copy link
Contributor

Yeah, if it's a straightforward one liner like three.js I should be able to take a look at it.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Dec 19, 2016

That would be great, thanks!

@pjcozzi pjcozzi added onramping priority - high and removed good first issue An opportunity for first time contributors labels Dec 20, 2016
@denverpierce
Copy link
Contributor

I crunched on this a bit but couldn't make any progress. Is the gltf spec the best resource to look at for this issue?

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Dec 28, 2016

Thanks for investigating, @denverpierce! I suspect the fix to three.js, mrdoob/three.js#10319, would be the best place to look, perhaps followed by the reference card, and then the spec.

@javagl
Copy link
Contributor

javagl commented Dec 28, 2016

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Dec 30, 2016

@cx20 the fix for this will be in Cesium 1.29, which will be released on Monday. Can you please update gltf-test?

@cx20
Copy link

cx20 commented Dec 31, 2016

I will update it as new version is released :)

@cx20
Copy link

cx20 commented Jan 2, 2017

I confirmed that WalkingLady glTF model is displayed in Cesium.js 1.29.
https://github.com/cx20/gltf-test

image

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 2, 2017

Great, thanks for the quick response, @cx20!

@denverpierce
Copy link
Contributor

Thanks to @javagl for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants