Added balance board support #125

sanjay900 · 2017-10-24T02:56:05Z

As always, dolphiimote changes are in this pr: maxmalmgren/DolphiiMote#2
Raw sensor values are exposed via Raw, and calibration data is exposed via CalibrationKG0, CalibrationKG17 and CalibrationKG34.
The values are converted to their equivalent weights using this data, and exposed as SensorsKG and SensorsLB, and the Total Weight is exposed via TotalWeightKG and TotalWeightLB. The center of gravity is also calculated and exposed via CenterOfGravityX and CenterOfGravityY.

sanjay900 · 2017-10-24T02:58:56Z

Do we want to change the AccelerationGlobal's file name to ControllerGlobal or something? because at this point it has all the global classes and not just Acceleration.

…at of other controllers

zelmon64 · 2017-10-24T11:18:56Z

@sanjay900 great work but there's a few issues. I agree AccelerationGlobal should probably be renamed ControllerGlobal unless you (@AndersMalmgren) world prefer something else.

I used the following script to test the board:

def log_balance_board():
	diagnostics.watch(wiimote[0].balance_board.raw.topLeft)
	diagnostics.watch(wiimote[0].balance_board.raw.topRight)
	diagnostics.watch(wiimote[0].balance_board.raw.bottomLeft)
	diagnostics.watch(wiimote[0].balance_board.raw.bottomRight)
	diagnostics.watch(wiimote[0].balance_board.sensorsKG.topLeft)
	diagnostics.watch(wiimote[0].balance_board.sensorsKG.topRight)
	diagnostics.watch(wiimote[0].balance_board.sensorsKG.bottomLeft)
	diagnostics.watch(wiimote[0].balance_board.sensorsKG.bottomRight)
	diagnostics.watch(wiimote[0].balance_board.totalWeightKG)
	diagnostics.watch(wiimote[0].balance_board.centerOfGravityX)
	diagnostics.watch(wiimote[0].balance_board.centerOfGravityY)

if starting:
	wiimote[0].balance_board.update += log_balance_board

centerOfGravityX(Y) should probably use the joystick convention of centerOfGravity.x(y)
centerOfGravityX world only give me 0 or -7 and centerOfGravityX always gave 12
totalWeightKG didn't give a stable value but was roughly correct
The spread of sensorsKG doesn't seem right.
- Typically a pair of values world be around 0 and the others around 70-120. As I shifted my weight about the transition jumps between 0 and 70.
- I would also expect the totalWeightKG to be the sum of sensorsKG but instead the components of sensorsKG were typically larger than (roughly double) totalWeightKG

Are you happy to look into these issues?

AndersMalmgren · 2017-10-24T11:26:16Z

@zelmon64 How about keeping only acc functions in that global and seperate the new behaviour to a new global? Wiimote is a bit more modular than the other plugins, since its so complex

zelmon64 · 2017-10-24T11:33:58Z

@AndersMalmgren Yes that makes more sense.

@sanjay900 are you happy to add that into this PR? I can do it after if not.

…ion and make the normal cog expose the cog like a joystick.

sanjay900 · 2017-10-25T07:46:03Z

So i have fixed sensors reporting incorrectly. I have also fixed COG so that it works correctly.

sanjay900 · 2017-10-25T07:50:15Z

Center of gravity seems to work well enough that i can bind it to mouse.deltaX(Y) and its smooth to move the mouse around.

sanjay900 · 2017-10-25T08:57:24Z

@zelmon64 I have moved the code from AccelerationGlobal to ExtensionGlobal.

zelmon64 · 2017-10-25T09:02:16Z

@sanjay900 thanks for continuing with this. Are you using vs 2017? I'm still on 2015 - I suppose I should upgrade.

I think the totalWeight_ is supposed to be the sum of the components, not the average. What it says on WiiBrew supports this. It's like if you stand on two scales (one under each foot) you would have to add their values to get your weight.

Thanks for moving to the new Global file.

sanjay900 · 2017-10-25T09:02:58Z

@zelmon64 Yeah i realised the code i was looking at was just completly wrong. Now that its fixed, summing the components is working fine.

sanjay900 · 2017-10-25T09:04:05Z

Also yeah, i am currently using 2017. This isn't causing you issues is it?

zelmon64 · 2017-10-25T09:11:36Z

Yes it is. I have to change some lines in the .vcxproj files to get it to work with 2015. I'm not sure what's best for DolphiiMote: keeping 2015 compatibility or upgrading to 2017. Might as well upgrade I suppose.

zelmon64 · 2017-10-25T10:57:23Z

@sanjay900 I tried it out and it seems to work perfectly now! Congratulations!

Now that centerOfGravity is split into x and y, I'm wondering if the rest would benefit from something similar like:

centerOfGravity
- x
- y
weight
- kg
- lb
- raw
sensors
- topLeft
  - kg
  - lb
  - raw
- topRight
  - kg
  - lb
  - raw
- bottomLeft
  - kg
  - lb
  - raw
- bottomLeft
  - kg
  - lb
  - raw
calibration
- kg00
  - topLeft
  - topRight
  - bottomLeft
  - bottomLeft
- kg17
  - topLeft
  - topRight
  - bottomLeft
  - bottomLeft
- kg34
  - topLeft
  - topRight
  - bottomLeft
  - bottomLeft

or even put the calibrations under the sensor corner selection like:

centerOfGravity
- x
- y
weight
- kg
- lb
- raw
sensors
- topLeft
  - kg
  - lb
  - raw
  - calibration
    - kg00
    - kg17
    - kg34
- topRight
  - kg
  - lb
  - raw
  - calibration
    - kg00
    - kg17
    - kg34
- bottomLeft
  - kg
  - lb
  - raw
  - calibration
    - kg00
    - kg17
    - kg34
- bottomLeft
  - kg
  - lb
  - raw
  - calibration
    - kg00
    - kg17
    - kg34

@AndersMalmgren what do you think? The current layout is:

centerOfGravity
- x
- y
totalWeightKG
totalWeightLB
sensorsKG
- topLeft
- topRight
- bottomLeft
- bottomLeft
sensorsLB
- topLeft
- topRight
- bottomLeft
- bottomLeft
calibrationKG0
- topLeft
- topRight
- bottomLeft
- bottomLeft
calibrationKG17
- topLeft
- topRight
- bottomLeft
- bottomLeft
calibrationK34
- topLeft
- topRight
- bottomLeft
- bottomLeft

sanjay900 · 2017-10-25T20:12:06Z

Ill start adding this in, since its easy enough to do either layout

AndersMalmgren · 2017-10-25T20:45:26Z

@zelmon64 I don't have stand point on it, do what you think is best

zelmon64 · 2017-10-25T21:43:20Z

@AndersMalmgren okay thanks ;)

@sanjay900 thanks. I think the second layout would best. Here it is again just to clarify:

centerOfGravity
- x
- y
weight
- kg
- lb
- raw
sensors
- topLeft
  - kg
  - lb
  - raw
  - calibration
    - kg00
    - kg17
    - kg34
- topRight
  - kg
  - lb
  - raw
  - calibration
    - kg00
    - kg17
    - kg34
- bottomLeft
  - kg
  - lb
  - raw
  - calibration
    - kg00
    - kg17
    - kg34
- bottomLeft
  - kg
  - lb
  - raw
  - calibration
    - kg00
    - kg17
    - kg34

sanjay900 · 2017-10-26T00:19:49Z

Cool, ill add that in when i get home.

…

On Thu, Oct 26, 2017 at 10:43 AM, William ***@***.***> wrote: @AndersMalmgren <https://github.com/andersmalmgren> okay thanks ;) @sanjay900 <https://github.com/sanjay900> thanks. I think the second layout would best. Here it is again just to clarify: - centerOfGravity - x - y - weight - kg - lb - raw - sensors - topLeft - kg - lb - raw - calibration - kg00 - kg17 - kg34 - topRight - kg - lb - raw - calibration - kg00 - kg17 - kg34 - bottomLeft - kg - lb - raw - calibration - kg00 - kg17 - kg34 - bottomLeft - kg - lb - raw - calibration - kg00 - kg17 - kg34 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#125 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABxsQHhwtY6GibJxpkOzzj7K-16U5NeNks5sv6t5gaJpZM4QDxbT> .

sanjay900 · 2017-10-26T07:34:17Z

@zelmon64 So i wonder if for debugging purposes it would be worth it to put toStrings on things. Just for me i currently have them on some of the balance board sensors, but i wonder if thats something that should be applied to more things?

sanjay900 · 2017-10-26T07:39:59Z

For example, now I can do testing with:

def log_balance_board():
	diagnostics.watch(wiimote[0].balance_board.sensors.bottomLeft)
	diagnostics.watch(wiimote[0].balance_board.sensors.bottomRight)
	diagnostics.watch(wiimote[0].balance_board.sensors.topLeft)
	diagnostics.watch(wiimote[0].balance_board.sensors.topRight)
	diagnostics.watch(wiimote[0].balance_board.weight)
	diagnostics.watch(wiimote[0].balance_board.centerOfGravity)

	diagnostics.watch(wiimote[0].buttons.button_down(WiimoteButtons.A))

if starting:
	wiimote[0].balance_board.update += log_balance_board

… AnalogStick

zelmon64 · 2017-10-26T08:13:23Z

@sanjay900 this looks great! That's really cool about the toStrings, I haven't seen that defore. I can see it would be useful but I'm hesitant about adding it to everything else.

One last thing to make this perfect. I think the names should be in lowerCamelCase. Currently some are but not all. I'm not certain how lowerCamelCase is supposed to be applied to names with numbers at the start but the kilogram symbol is normally supposed to be lower case so I think that would bo best (same with lb).

zelmon64 · 2017-10-26T08:53:58Z

@sanjay900 Thank you! :D

Have you changed your github account email? Your username is showing as @invalid-email-address.

sanjay900 · 2017-10-26T08:54:34Z

I guess something wasn't set up right when i reinstalled.

sanjay900 · 2017-10-26T08:55:56Z

Ah i see, a tool i ran appears to have changed my git username and email

sanjay900 · 2017-10-26T09:44:24Z

Cool, i have changed the toString output a little bit so that it formats nicer when printing the balance_board object.

zelmon64 · 2017-10-26T09:49:16Z

@sanjay900 ooh very nice! I'm getting ready to merge this unless there's more you want to tweak.

Could you also post your board to mouse script please? I'm having some difficulty.

sanjay900 · 2017-10-26T09:50:51Z

mouse.deltaX = wiimote[0].balanceBoard.centerOfGravity.x/10
mouse.deltaY = wiimote[0].balanceBoard.centerOfGravity.y/10

@zelmon64 I think i am done now, so we should be good for a merge.
This should just move the mouse around by leaning from side to side.

zelmon64 · 2017-10-26T09:58:25Z

@sanjay900 Great!

I must have some conflicting software because that's basically how I've been trying to move the mouse. All it does for me is force the mouse to the bottom right corner. Oh well

sanjay900 · 2017-10-26T10:00:00Z

Weird, maybe we should look into giving the mouse plugin a little more functionality like getting and setting cursor position, instead of just deltas.

zelmon64 · 2017-10-26T10:12:03Z

@sanjay900 maybe. What do you fancy tackling next? Do you have any more unsupported controllers?

After I merge your DolphiiMote work I'm going to combine it with the improved wiimote passthrough mode I've been working on. Would you mind testing it with you guitar when it's ready please?

sanjay900 · 2017-10-26T10:13:30Z

@zelmon64 I haven't got any more controllers, however now that i have all my other controllers back i can test your passthrough mode when its ready. Going to be interesting putting a guitar in passthrough mode though haha.

sanjay900 · 2017-10-26T10:14:23Z

@zelmon64 I may tackle the mouse thing since i did actually have a need for it a while ago and just hacked something in, but it would be much nicer to have it as built in functionality.

zelmon64 · 2017-10-26T13:47:46Z

@sanjay900 I've uploaded a build on mtbs3d with the modified DolphiiMote for wiimote passthrough mode. There's an example script to show you how to enable it. It doesn't seem to succeed 100% of the time but should after a restarting the script a couple of times (I haven't figured out why yet).

JabberwockPL · 2017-10-26T14:13:43Z

Great work on the balance board! I have been wishing for that (and nagging everyone on the forum) for a long time!

As for the mouse, while you are at it, you might also look into grabbing absolute input and/or DirectX input. The former could be useful for controllers such as drawing tablets (I got mine to work as a lightgun, but with additional software), the latter might make easier such schemes like controlling planes etc. with mouse (as it makes recentering easier).

sanjay900 · 2017-10-27T03:12:24Z

@zelmon64 So the guitar does not work - atleast not through the guitar. However, it is being passed through as i can see values change on the nunchuck when i alter the guitar.

sanjay900 · 2017-10-27T03:13:34Z

@zelmon64 Could you possibly push your changes so i can look at them?

zelmon64 · 2017-10-27T07:58:17Z

@sanjay900 my changes are on this branch:
https://github.com/zelmon64/DolphiiMote/tree/simultaneous_extensions

Did you try the DolphiiMote test app or FreePIE?

sanjay900 · 2017-10-27T18:03:52Z

Freepie

sanjay900 · 2017-10-27T18:28:17Z

However the same happens with dolphiimote test.

sanjay900 · 2017-10-28T00:55:21Z

@zelmon64 I think i have an idea as to why this happens. It is also a problem with classic controllers, I will fix this on my own fork of your branch.

Added balance board support

9394cce

sanjay900 mentioned this pull request Oct 24, 2017

Add support for guitar hero controllers #123

Merged

Changed case of BalanceBoardGlobal fields so that they match the form…

7aa18c8

…at of other controllers

BuildTools added 2 commits October 25, 2017 13:04

Expose center of gravity as a joystick instead of seperate values

be5e978

Fix balanceboard values being calculated incorrectly, add a cog posit…

3d0c05c

…ion and make the normal cog expose the cog like a joystick.

BuildTools added 2 commits October 25, 2017 21:47

Change calculation of COG, remove position as it is unnecessary now

02b3e52

Moved code from AccelerationGlobal to ExtensionGlobal

f398b76

BuildTools added 3 commits October 26, 2017 20:41

Refactor BalanceBoard, add toString to BalanceBoard + AnalogTrigger +…

85198f2

… AnalogStick

Add a few more ToStrings, CenterOfGravity -> centerOfGravity

5a1f593

Make the console show messages not stack traces

e2153c5

Make toStrings lowerCamelCase

91c2dd7

Format toStrings nicer with newlines

1d09719

sanjay900 added 2 commits October 26, 2017 22:46

classic_controller -> classicController, balance_board -> balanceBoard

abcc16b

classic_controller -> classicController, balance_board -> balanceBoard

d59ba36

zelmon64 merged commit c0b2116 into AndersMalmgren:master Oct 26, 2017

sanjay900 deleted the AddBalanceBoardSupport branch October 26, 2017 10:35

Added balance board support #125

Added balance board support #125

Conversation

sanjay900 commented Oct 24, 2017 • edited Loading

sanjay900 commented Oct 24, 2017

zelmon64 commented Oct 24, 2017

AndersMalmgren commented Oct 24, 2017

zelmon64 commented Oct 24, 2017

sanjay900 commented Oct 25, 2017 • edited Loading

sanjay900 commented Oct 25, 2017 • edited Loading

sanjay900 commented Oct 25, 2017

zelmon64 commented Oct 25, 2017

sanjay900 commented Oct 25, 2017

sanjay900 commented Oct 25, 2017

zelmon64 commented Oct 25, 2017

zelmon64 commented Oct 25, 2017

sanjay900 commented Oct 25, 2017

AndersMalmgren commented Oct 25, 2017

zelmon64 commented Oct 25, 2017

sanjay900 commented Oct 26, 2017 via email

sanjay900 commented Oct 26, 2017

sanjay900 commented Oct 26, 2017

zelmon64 commented Oct 26, 2017

zelmon64 commented Oct 26, 2017

sanjay900 commented Oct 26, 2017

sanjay900 commented Oct 26, 2017

sanjay900 commented Oct 26, 2017

zelmon64 commented Oct 26, 2017

sanjay900 commented Oct 26, 2017 • edited Loading

zelmon64 commented Oct 26, 2017

sanjay900 commented Oct 26, 2017 • edited Loading

zelmon64 commented Oct 26, 2017

sanjay900 commented Oct 26, 2017 • edited Loading

sanjay900 commented Oct 26, 2017 • edited Loading

zelmon64 commented Oct 26, 2017

JabberwockPL commented Oct 26, 2017

sanjay900 commented Oct 27, 2017

sanjay900 commented Oct 27, 2017

zelmon64 commented Oct 27, 2017

sanjay900 commented Oct 27, 2017

sanjay900 commented Oct 27, 2017

sanjay900 commented Oct 28, 2017

sanjay900 commented Oct 24, 2017 •

edited

Loading

sanjay900 commented Oct 25, 2017 •

edited

Loading

sanjay900 commented Oct 25, 2017 •

edited

Loading

sanjay900 commented Oct 26, 2017 •

edited

Loading

sanjay900 commented Oct 26, 2017 •

edited

Loading

sanjay900 commented Oct 26, 2017 •

edited

Loading

sanjay900 commented Oct 26, 2017 •

edited

Loading