Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Configurable _messageTopMargin #147

Open
rayliverified opened this issue Jun 11, 2020 · 0 comments
Open

User Configurable _messageTopMargin #147

rayliverified opened this issue Jun 11, 2020 · 0 comments

Comments

@rayliverified
Copy link

rayliverified commented Jun 11, 2020

Describe the bug
_messageTopMargin is hardcoded to 6.0. Allow this value to be user configurable.

Paste relevant code
_messageTopMargin = _isTitlePresent ? 6.0 : widget.padding.top;

Solution
There are two solutions:

  • (Preferred) Remove _messageTopMargin. Allow the user to control padding through widget passed in title or message.
  • Expose setter for _messageTopMargin

Please let me know what you think. I'm happy to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant