Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.2 does not start #160

Open
bergentroll opened this issue Jan 17, 2021 · 3 comments
Open

4.1.2 does not start #160

bergentroll opened this issue Jan 17, 2021 · 3 comments

Comments

@bergentroll
Copy link
Contributor

bergentroll commented Jan 17, 2021

On running Wyrmsun v4.1.2 I see only black window that immediately dissapears and this short log output:

[2021.01.17 20:26:44] Position (188, 179) of map template "earth_45_60_latitude_north" already has a site ("trent").
[2021.01.17 20:26:44] Failed to initialize the site instance "bozen".
[2021.01.17 20:26:44] Error initializing the instances of the site class.
[2021.01.17 20:26:44] Error initializing database.
Thanks for playing Stratagus.
@bergentroll bergentroll changed the title 4.1.2 4.1.2 does not start Jan 17, 2021
@bergentroll
Copy link
Contributor Author

I am not sure is it related to this repo or to Wyrmsun.

@Andrettin
Copy link
Owner

Thanks for reporting the issue! It seems probable that this is related to floating-point operations. Positions for sites are derived from geocoordinates with doubles used for their longitude and latitude. Since Bozen/Bolsano and Trent/Trento are close to each other, possibly a floating point issue led them to be placed in the same tile for your computer.

I am working on a fix, changing geocoordinates to use an underlying integer instead, so as to make their conversion to tile positions more deterministic.

@Andrettin
Copy link
Owner

I've implemented the change I mentioned above, potentially fixing this issue:
efa41c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants