Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/buildSrc-version-catalogue #88

Merged
merged 5 commits into from
Nov 15, 2022

Conversation

wax911
Copy link
Member

@wax911 wax911 commented Nov 14, 2022

Pull Request Template

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • You have followed our contributing guidelines
  • double-check your branch is based on develop and targets develop
  • Pull request has tests (If applicable)
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved
  • I did not commit files that are excluded in the .gitignore file (Happens if you stage files with Android Studio)

Description

Architectural change for migrating away from buildSrc -> Libraries to version catalogs using an externalised .toml file

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the Apache License.

@wax911 wax911 merged commit 0f10e4e into develop Nov 15, 2022
@wax911 wax911 deleted the refactor/buildSrc-version-catalogue branch November 15, 2022 13:30
@wax911 wax911 changed the title Refactor/buildSrc version catalog refactor/buildSrc-version-catalogue Feb 18, 2023
@wax911 wax911 added the enhancement Improve existing functionality label Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant