Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarball folder (/opt/src) is hardcoded and thus not configurable #35

Closed
lhoss opened this issue Aug 8, 2016 · 8 comments
Closed

tarball folder (/opt/src) is hardcoded and thus not configurable #35

lhoss opened this issue Aug 8, 2016 · 8 comments

Comments

@lhoss
Copy link

lhoss commented Aug 8, 2016

we don't use /opt (instead another special subdir in /usr/local), so we need this to be configurable.

I already fixed this locally and ready to make a PR (after #34 got merged)

@ernestas-poskus
Copy link
Member

Why it's not configurable ? In Ansible you can override default variables

@lhoss
Copy link
Author

lhoss commented Aug 8, 2016

but this path (/opt/src) is not yet a role variable, see tarball.yml

@ernestas-poskus
Copy link
Member

@lhoss yes you are right, then I suggest to extract it into variable leave default as it is and you will be able to change it to satisfy your needs

@lhoss
Copy link
Author

lhoss commented Aug 10, 2016

that's how I've implemented it (will create PR latest tomorrow, after #34 merge), adding new variable:

zookeeper_tarball_dir: /opt/src

@ernestas-poskus
Copy link
Member

ernestas-poskus commented Aug 10, 2016

@lhoss again thank you for contribution, your PR's merged into 0.11.0 release

@lhoss
Copy link
Author

lhoss commented Aug 10, 2016

happy to contribute !
keeping up the improvements, just created #38

@lhoss
Copy link
Author

lhoss commented Aug 11, 2016

you can close
#38 fixed this

@ernestas-poskus
Copy link
Member

issue resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants