Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forme DTO does not support "primary forme" #58

Closed
Antar1011 opened this issue Sep 27, 2016 · 2 comments
Closed

Forme DTO does not support "primary forme" #58

Antar1011 opened this issue Sep 27, 2016 · 2 comments
Labels
bug
Milestone
0.1 Release

Comments

@Antar1011
Copy link
Owner

Giant irony to this comment, which caused me to rip out and rewrite the entire SQL backend: forme lists in the DTO get ordered alphabetically upon sanitizing.

It's possible that the policy will be that the ordering doesn't matter (so count "Mega-Charizard-XMega-Y" and "Mega-Charizard-Y-Mega-X" together), but that shouldn't be baked in.
@Antar1011 Antar1011 added the bug label Sep 27, 2016
@Antar1011 Antar1011 added this to the 0.1 Release milestone Sep 27, 2016
@Antar1011
Copy link
Owner Author

Okay, to be clear, it's the Moveset DTO, not the Forme DTO, that's the problem

@Antar1011
Copy link
Owner Author

This is in progress on the forme-refactor branch

@Antar1011 Antar1011 mentioned this issue Sep 29, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.1 Release
Development

No branches or pull requests
1 participant
@Antar1011