Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enabled property to ST storage objects, fix bug in save #1839

Merged
merged 8 commits into from
Dec 21, 2023

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Dec 21, 2023

No description provided.

flomnes and others added 5 commits November 21, 2023 16:35
…ing ST objects (#1807)

- Add bool property `enabled` for each ST storage object
- Whenever a ST storage is not `enabled`, remove it from computations
relatively early (right after loading the data), using a similar
mechanism as thermal & renewable clusters
- Also fix list.ini files containing only the last ST storage object
because of overwrite, add unit test case
- Cherry-pick of "Remove sts container (#1804)"

---------

Co-authored-by: Vincent Payet <vincent.payet@rte-france.com>
Co-authored-by: payetvin <113102157+payetvin@users.noreply.github.com>
Copy link

watermelon-copilot-for-code-review bot commented Dec 21, 2023

Watermelon AI Summary

AI Summary deactivated by flomnes

GitHub PRs

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

@flomnes flomnes changed the title Add enabled property to ST storage objects Add enabled property to ST storage objects, fix bug in save Dec 21, 2023
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@flomnes flomnes merged commit 51d6bd4 into develop Dec 21, 2023
5 of 6 checks passed
@flomnes flomnes deleted the fix/enabled-save branch December 21, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants