Hydro final lvl (CR 25) to merge in develop [ANT-1084] #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSR comments implementation update
Issue-66 update
Implement latest CSR comments
|
Kudos, SonarCloud Quality Gate passed! |
flomnes
changed the title
This was referenced Dec 11, 2023
This was referenced Dec 21, 2023
|
|
See comments to know more about this PR intentions. Furthermore, a study testing final levels can be found here below. Please read this study's user's notes for the test goals and how to fulfill them. [final-levels.zip](https://github.com/AntaresSimulatorTeam/Antares_Simulator/files/15126508/final-levels.zip)
flomnes
changed the title
…final-levels-cr25--try-fixes
|
Final reservoir level not applicable should be a warning, not an info |
flomnes
requested changes
Jun 17, 2024
Comment on lines
123
to
125
| hydroLevelsData hydroInitialLevels = hydroLevelsData("hl,", initLevelApply); | ||
| //! hydro final levels | ||
| hydroLevelsData hydroFinalLevels = hydroLevelsData("hfl,", finalLevelApply); |
There was a problem hiding this comment.
Suggested change
| hydroLevelsData hydroInitialLevels = hydroLevelsData("hl,", initLevelApply); | |
| //! hydro final levels | |
| hydroLevelsData hydroFinalLevels = hydroLevelsData("hfl,", finalLevelApply); | |
| hydroLevelsData hydroInitialLevels{"hl,", initLevelApply}; | |
| //! hydro final levels | |
| hydroLevelsData hydroFinalLevels{"hfl,", finalLevelApply}; |
src/antares-deps
Outdated
| if (hydro_.reservoirManagement && !hydro_.useWaterValue) | ||
| return true; | ||
|
|
||
| logs.info() << "Final reservoir level not applicable! Year:" << year_ + 1 |
There was a problem hiding this comment.
Suggested change
| logs.info() << "Final reservoir level not applicable! Year:" << year_ + 1 | |
| logs.warning() << "Final reservoir level not applicable! Year:" << year_ + 1 |
Recall : **Hydro allocation** is done at the beginning of each MC year, and ends with a quantity of hydro energy for each day of the year. These daily quantities are to be used as daily hydro generations in the optimization problem. The **hydro debug** functionality allows to print (if asked by user) on disk a **report** about **hydro allocation results**. This hydro allocation report is broken (a crash comes up). It was broken since January 2023 (a commit can be supplied if needed). This PR to fix this crash.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts some code enhancements on branch feature/final-reservoir-level-cr25.
Therefore, this PR's associated branch (fix/hydro-final-levels-cr25--try-fixes) is based on feature/final-reservoir-level-cr25.
For any purpose, here are doc resources :
CAUTION :
Some cleaning and corrections were introduced in a new pull request (see this PR).
This new PR was merged into this one.
This PR contains a test under the form of a study.
This study should be downloaded and added to the right test repo.
Left to to