Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handoff in materializer_vnode #203

Open
deepthidevaki opened this issue May 18, 2016 · 2 comments
Open

Handoff in materializer_vnode #203

deepthidevaki opened this issue May 18, 2016 · 2 comments
Labels

Comments

@deepthidevaki
Copy link
Member

After handoff, the operations may be applied twice. This is because, logging_vnode does the handoff and gets the operations to the log. materializer_vnode does the handoff independently, and caches the operations. Then (for some executions) the load_from_log in the materilizer_vnode re-loads the operation that is already cached by the handoff, thus duplicating them.
The test is in the branch handoff_materiliazer riak_test/log_handoff_test.erl.

@tcrain
Copy link
Contributor

tcrain commented May 18, 2016

Ok, it looks like I introduced this when add the recovery from the log, so I will fix it. The test you mention will fail on master? Can I use it to test if the fix I will make works?

@deepthidevaki
Copy link
Member Author

Yes. It fails on master. It is the same test that is in the master, but with op-crdts. The bug is hidden with state based crdts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants