New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graceful-teardown: warns about usage of `require` in `t.Cleanup` functions and suite teardown methods #142

Open

Antonboom opened this issue Jun 21, 2024 · 0 comments

Labels

Milestone

v1.7.0 New 2 comp...

Owner

Antonboom commented Jun 21, 2024

func (s *ServiceIntegrationSuite) TearDownTest() {
    if p := s.verdictsProducer; p != nil {
        s.Require().NoError(p.Close()) ❌
    }
    if c := s.dlqVerdictsConsumer; c != nil {
        s.NoError(c.Close())
    }
    s.DBSuite.TearDownTest()
    s.ks.TearDownTest()
}

Antonboom added the enhancement label

Antonboom added this to the v1.7.0 New 2 complex checkers milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment