Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework API for failure/success signaling #16

Open
3 of 4 tasks
lucab opened this issue Sep 25, 2015 · 1 comment
Open
3 of 4 tasks

Rework API for failure/success signaling #16

lucab opened this issue Sep 25, 2015 · 1 comment
Labels
enhancement

Comments

@lucab
Copy link
Contributor

lucab commented Sep 25, 2015

Currently there are several parts of rust-amqp where errors are being sunk, due to API not providing return values to signal errors/success. In order to be fixed, this requires changing existing API to signal all possible errors.

Troubling methods spotted so far:

  • Channel::close()
  • Channel::write()
  • Channel::send_method_frame()
  • most of Basic

(More will follow after further inspection)
@Antti
Copy link
Owner

Antti commented Sep 25, 2015

Fixed all channel related ones, fixed most of the Basic, only Iterator implementation left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Antti @lucab