Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysql #85

Merged
merged 55 commits into from
Jun 21, 2019
Merged

Mysql #85

merged 55 commits into from
Jun 21, 2019

Conversation

jssuzanne
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 92.377% when pulling c9eafaa on jssuzanne:mysql into 00c3827 on AnyBlok:master.

@coveralls
Copy link

coveralls commented May 9, 2019

Coverage Status

Coverage decreased (-0.02%) to 92.379% when pulling 0335cf0 on jssuzanne:mysql into 00c3827 on AnyBlok:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 92.377% when pulling c9eafaa on jssuzanne:mysql into 00c3827 on AnyBlok:master.

@petrus-v
Copy link
Contributor

petrus-v commented May 9, 2019

Great ! testing anyblok against mysql ! looks like it'll require some extra effort to fix some tests

👏 for that effort

@@ -517,6 +517,8 @@ def test_datetime_by_query_filter(self):
registry = self.init_registry(simple_column, ColumnType=DateTime)
test = registry.Test.insert(col=now)
Test = registry.Test
import ipdb
ipdb.set_trace()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel you wanted to include it in you commit ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok forgot me I jump to a commit instead reading the whole diff

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was a bad commit

@jssuzanne jssuzanne merged commit cf2f484 into AnyBlok:master Jun 21, 2019
@jssuzanne jssuzanne deleted the mysql branch June 21, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants