Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externals in Dialects #99

Closed
NeuralCoder3 opened this issue Oct 10, 2022 · 1 comment
Closed

Externals in Dialects #99

NeuralCoder3 opened this issue Oct 10, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@NeuralCoder3
Copy link
Collaborator

Dialects currently can not declare externals.
This is probably due to multiple reads of the dialect thorin file.

This behavior can be observed in the automatic differentiation branch.

The intermediate fix is to disable the insertion/containment check in world.h.
@NeuralCoder3 NeuralCoder3 changed the title Externals Externals in Dialects Oct 10, 2022
@NeuralCoder3 NeuralCoder3 mentioned this issue Oct 10, 2022
Merged
13 tasks
@leissa leissa mentioned this issue Oct 11, 2022
Closed
@leissa leissa added the bug Something isn't working label Oct 12, 2022
@leissa leissa mentioned this issue Mar 8, 2023
Merged
@leissa
Copy link
Member

leissa commented Mar 27, 2023

Fixed by #185

@leissa leissa closed this as completed Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leissa @NeuralCoder3