-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support Etherscan rate limit [APE-774] #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing PR! works great i think, tho going to test a little longer.
i wish there were tests. could use the mock client to raise a 429 once in a side-effect and then return the correct response the second time.
i can help add the test tho at some point...
@antazoey are you on the ape discord, couldn't see anyone with the same pic (mine is also different). |
im antazoey#5084 on discord, same pic |
Are you suggesting adding a new class to |
i think there is an |
tests only failing because of secrets / forked repo etc |
What I did
fixes: #
How I did it
How to verify it
Checklist
Overrides #77