Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: base fee config appears to no longer work #94

Closed
mikeshultz opened this issue Mar 6, 2024 · 2 comments · Fixed by #95
Closed

bug: base fee config appears to no longer work #94

mikeshultz opened this issue Mar 6, 2024 · 2 comments · Fixed by #95
Assignees
Labels
category: bug Something isn't working category: testing Test plan for an existing feature

Comments

@mikeshultz
Copy link
Member

Environment information

CI

What went wrong?

# Show we can se the base-fee.
        new_base_fee = 1_000_000
        data = {"foundry": {"base_fee": new_base_fee, "host": "http://127.0.0.1:8555/"}}
        with temp_config(data):
            with networks.ethereum.local.use_provider("foundry") as provider:
>               assert provider.base_fee == new_base_fee
E               assert 875000 == 1000000
E                +  where 875000 = <foundry chain_id=31337>.base_fee

/home/runner/work/ape-foundry/ape-foundry/tests/test_provider.py:292: AssertionError

Base fee config test appears to be failing for some reason.

Ref: https://github.com/ApeWorX/ape-foundry/actions/runs/8167913540/job/22329080151?pr=93

How can it be fixed?

Unclear. Could be an upstream ape issue?

Copy link

linear bot commented Mar 6, 2024

@mikeshultz mikeshultz added category: bug Something isn't working category: testing Test plan for an existing feature labels Mar 6, 2024
@mikeshultz mikeshultz self-assigned this Mar 6, 2024
@mikeshultz
Copy link
Member Author

Should be fixed by #95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug Something isn't working category: testing Test plan for an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant