Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Version objects for solc versions #17

Closed
iamdefinitelyahuman opened this issue Sep 3, 2019 · 1 comment
Closed

Use Version objects for solc versions #17

iamdefinitelyahuman opened this issue Sep 3, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@iamdefinitelyahuman
Copy link
Contributor

iamdefinitelyahuman commented Sep 3, 2019

Overview

Use Version objects to represent solc versions, instead of strings.

Specification

  1. solcx/install.py - store the solc_version variable as a Version and update related code.
  2. Return Version object(s) anywhere a version is returned to a user, e.g. get_available_solc_versions and get_installed_solc_versions
  3. All functions receiving a version in the user input should be able to understand both strings and Version objects, e.g. set_solc_version, install_solc
  4. Remove the get_solc_version_string method (this information is still available from get_solc_version).
  5. Update unit tests to ensure all new/modified code is adequately covered.

References

Dependencies

This will amount to a breaking change, so cannot happen until 1.0.0.

@pegahcarter
Copy link

I got this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants