Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better example display #595

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

Haniyya
Copy link
Contributor

@Haniyya Haniyya commented Jan 16, 2018

⚠️ This PR depends on #597 and #598. Please process these first


This PR Improves and fixes changes to the UI that were introduced in #598 and starts to utilize #597 as well.
As these changes are depended on their predecessors, i advise to merge those first as the changes will become minimal once they are incorporated.

This PR basically isolates certain markdown related things that were not needed for the changes in the PRs mentioned above but will be necessary for a good user experience once those are merged.

@Haniyya
Copy link
Contributor Author

Haniyya commented Jan 16, 2018

WIP since i probably need to fix/write some tests still.

@iNecas
Copy link
Member

iNecas commented Jan 16, 2018

Would it be possible to split the PR into some smaller isolated PRs that could be reviewed separately? Big PRs are usually harder to tackle.

@Haniyya
Copy link
Contributor Author

Haniyya commented Jan 17, 2018

@iNecas I could split it into 3 that correlate to the three features mentioned above if thats okay.

@iNecas
Copy link
Member

iNecas commented Jan 17, 2018

Yes please

This was referenced Jan 17, 2018
@Haniyya Haniyya changed the title WIP: Feature/better example display Better example display Jan 17, 2018
@Haniyya
Copy link
Contributor Author

Haniyya commented Jan 17, 2018

@iNecas I tried to isolate the changes as best i could but #598 still turned out to be quite big. This is mostly down to the changes in markup that are necessary to have any effect on the user experience.

@ofedoren ofedoren force-pushed the master branch 2 times, most recently from 69442b9 to 8215e30 Compare July 25, 2021 19:41
@mathieujobin mathieujobin added the Stale waiting for update label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale waiting for update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants