Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine Eigenvectors object with InteractionRotation #290

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Combine Eigenvectors object with InteractionRotation #290

merged 3 commits into from
Jan 19, 2024

Conversation

danbraunai-apollo
Copy link
Contributor

@danbraunai-apollo danbraunai-apollo commented Jan 18, 2024 •
edited
Loading

Combine Eigenvectors object with InteractionRotation

Description

  • Now have a single InteractionRotation object which contains node_layer_name, out_dim, C, C_pinv, W, W_pinv, V, Lambda
  • Rebuilt graphs with the new results object (so that the ablation tests pass).

Does this PR introduce a breaking change?

Yes. The RibResults interface has changed

@danbraunai-apollo danbraunai-apollo merged commit a44f992 into feature/unify Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nix-apollo nix-apollo nix-apollo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danbraunai-apollo @nix-apollo