Major Refactoring #260
Merged
Major Refactoring #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Combine lm and mlp ablation scripts * Use sample graphs in ablation configs
* Move rib build and plot inside rib package * Rename experiments to rib_scripts and update setup.py * Move all ablation logic to rib/ablations.py * Test update venv in CI * Revert test change in CI * Fix package finding in setup.py
* Make RibResults a pydantic model * Save model config object instead of dict in RibResults
* Store edges in Edges pydantic model * Simplify edge_combiner
* Rename variables and clean docs * Update rib_builder.py module docstring
nix-apollo
requested changes
Jan 16, 2024
* ablations cleanups * ignore old out files * edge storing loop simplify * merge model loading * clean test configs * revert load dataset chagne * Fix naming and docs * important fix --------- Co-authored-by: Dan Braun <dan@apolloresearch.ai>
* Rename torch types * Fix raw input torch types * Fix tuple annotation for unknown emb size * Fix docs and types
* Remove extra return_set arg and fix model_copy * Move get_config functions to tests.utils
danbraunai-apollo
force-pushed
the
feature/unify
branch
from
5f5c635
to
bf4d8d4
Compare
nix-apollo
reviewed
Jan 18, 2024
nix-apollo
reviewed
Jan 18, 2024
nix-apollo
reviewed
Jan 18, 2024
danbraunai-apollo
added a commit
that referenced
this pull request
Jan 18, 2024
* Combine Eigenvectors object with InteractionRotation * Address misc comments in PR #260 * Rename variables and update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Refactoring
Description
Major refactor. See PRs (and commits) within this PR for descriptions of each change. The main changes are:
rib_scripts/rib_buildand all ablation experiments inrib_scripts/ablations.Related Issue
Closes #228; Closes #236; Closes #266; Closes #265; Closes #261; Closes #192
Does this PR introduce a breaking change?
Yes. Too many to enumerate. See PRs within this PR for a non-exhaustive list.