-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 9 SDK #2003
base: main
Are you sure you want to change the base?
Update to .NET 9 SDK #2003
Conversation
- Fix CA1849 warning from updating snippets to .NET 8. - Fix IDE0034 warning identified by the .NET 9 SDK in App-vNext#2003.
- Update various sample projects from `net7.0` to `net8.0`. - Fix CA1849 warning from updating snippets to .NET 8. - Fix IDE0034 warning identified by the .NET 9 SDK in #2003.
a29ccc2
to
7ca1b0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
=======================================
Coverage ? 83.65%
=======================================
Files ? 311
Lines ? 7096
Branches ? 1050
=======================================
Hits ? 5936
Misses ? 789
Partials ? 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
336f454
to
7952a24
Compare
7952a24
to
ee658b4
Compare
6200a8c
to
a26bc60
Compare
<!-- HACK net9.0 compilation for the tests fails due to missing Task.Delay() extension for TimeProvider without this reference --> | ||
<PackageReference Include="Microsoft.Bcl.TimeProvider" Condition="$([MSBuild]::IsTargetFrameworkCompatible($(TargetFramework), 'net9.0'))" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martintmk Any idea what's going on with this? Without an explicit reference to this package, I can't get the tests to compile for net9.0
.
The only change I can see that might explain it is this from dotnet/extensions#5058.
Fix IDE0057 warnings identified in App-vNext#2003.
Fix IDE0057 warnings identified in #2003.
e823391
to
36ecb34
Compare
36ecb34
to
82a3c08
Compare
bee5858
to
eeac2c2
Compare
f18d2e9
to
ff96865
Compare
- Update to preview 1 of the .NET 9 SDK. - Target `net8.0` and `net9.0` in tests, samples and benchmarks. - Remove `net6.0` and `net7.0` targets from tests, samples and benchmarks. - Simplify AoT properties. - Only analyse for AoT for .NET 8+ to resolve new warning. - Force docfx to use .NET 9 SDK. - Fix new IDE0034 warning.
Just validate with `net9.0` to avoid complexity of publishing the AoT app twice when Polly will just use `net8.0` both times anyway.
Skip test that breaks the VSTest process in release mode for .NET 9.
Reduce coverage threshold while test skipped.
Add link to issue for skipped test.
Update to preview 2 of the .NET 9 SDK.
* Update .NET SDK Update .NET SDK to version 9.0.100-preview.3.24204.13. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> * Bump Microsoft.Extensions.TimeProvider.Testing Bump Microsoft.Extensions.TimeProvider.Testing for .NET 9 preview 3. --------- Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> Co-authored-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
Test no longer appears to fail with .NET 9 preview 3.
Accidentally deleted, rather than updated.
Update to preview 4 of .NET 9.
ff96865
to
4bc4037
Compare
* Update .NET SDK Update .NET SDK to version 9.0.100-preview.5.24307.3. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> * Update packages - Update NuGet packages for .NET 9 preview 5. - Trigger builds for PRs to the dotnet-vnext branch. --------- Signed-off-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> Co-authored-by: polly-updater-bot[bot] <138034000+polly-updater-bot[bot]@users.noreply.github.com> Co-authored-by: Martin Costello <martin@martincostello.com>
A long-lived PR for testing .NET 9 until the stable release in November 2024.
net9.0
is explicitly not being added as a new TFM for the packages we ship to NuGet.org.Changes include:
net8.0
andnet9.0
in tests, samples and benchmarks.net6.0
andnet7.0
targets from tests, samples and benchmarks as they will both be out-of-support by November 2023.