Port fixes from .NET 9 testing #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix IDE0057 warnings identified in App-vNext#2003.
Suppress xUnit1031 warnings in tests that explicitly test synchronous behaviours.
- Remove properties that are implied by `IsAotCompatible=true`. - Only mark as AoT-compatible for `net8.0` where it's actually supported.
Fix test not being declared in a namespace.
- Bump the samples' reference to ourself to the latest version. - Bump `Microsoft.Extensions.TimeProvider.Testing` to 8.4.0. - Use an MSBuild property to allow for easy conditions for multi-targeting.
martincostello
added
enhancement
CI/build
dependencies
Add package reference to Microsoft.Bcl.TimeProvider as Microsoft.Extensions.TimeProvider.Testing appears to have trimmed the dependency away.
Add `VersionOverride` to fix package downgrade warning.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
=======================================
Coverage 83.67% 83.67%
=======================================
Files 312 312
Lines 7105 7106 +1
Branches 1054 1054
=======================================
+ Hits 5945 5946 +1
Misses 789 789
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martintmk
reviewed
Apr 12, 2024
martintmk
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port various changes/fixes from #2003 that don't depend on .NET 9.
IsAotCompatible=true.net8.0where it's actually supported.Microsoft.Extensions.TimeProvider.Testingto 8.4.0.