Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: active hover on upload image #597

Merged

Conversation

johansutrisno
Copy link
Contributor

@johansutrisno johansutrisno commented Nov 18, 2023

Linked to #384 and #368

[Bug]: Active hover on upload image

Before

Screen.Recording.2023-11-18.at.22.57.02.mov

After

Screen.Recording.2023-11-18.at.22.57.49.mov

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (e41204d) 78.87% compared to head (cd7b59d) 78.87%.

Files Patch % Lines
...ent/image_block_component/image_upload_widget.dart 50.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   78.87%   78.87%           
=======================================
  Files         289      289           
  Lines       12525    12526    +1     
=======================================
+ Hits         9879     9880    +1     
  Misses       2646     2646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 82573c9 into AppFlowy-IO:main Jan 1, 2024
9 of 10 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 4, 2024
* main:
  feat: table navigation using TAB key (AppFlowy-IO#627)
  feat: add markdown link syntax formatting (AppFlowy-IO#618)
  fix:text_decoration_mobile_toolbar_padding (AppFlowy-IO#621)
  fix: active hover on upload image (AppFlowy-IO#597)
  feat: adding an ability to have a link check before embedding (AppFlowy-IO#603)
  fix: node_iterator toList encounter Dangling Node trigger dead loop. (AppFlowy-IO#623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants