Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve dead loop in node_iterator toList #623

Merged
merged 2 commits into from
Jan 1, 2024
Merged

fix: resolve dead loop in node_iterator toList #623

merged 2 commits into from
Jan 1, 2024

Conversation

Linij
Copy link
Contributor

@Linij Linij commented Dec 15, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2023

CLA assistant check
All committers have signed the CLA.

@Linij Linij changed the title fix: node_iterator toList encounter Dangling Node trigger dead loop. fix: resolve dead loop in node_iterator toList Dec 19, 2023
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20a714a) 78.08% compared to head (59d75ea) 78.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #623   +/-   ##
=======================================
  Coverage   78.08%   78.09%           
=======================================
  Files         290      290           
  Lines       12732    12734    +2     
=======================================
+ Hits         9942     9944    +2     
  Misses       2790     2790           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 87068d1 into AppFlowy-IO:main Jan 1, 2024
8 of 11 checks passed
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Jan 4, 2024
* main:
  feat: table navigation using TAB key (AppFlowy-IO#627)
  feat: add markdown link syntax formatting (AppFlowy-IO#618)
  fix:text_decoration_mobile_toolbar_padding (AppFlowy-IO#621)
  fix: active hover on upload image (AppFlowy-IO#597)
  feat: adding an ability to have a link check before embedding (AppFlowy-IO#603)
  fix: node_iterator toList encounter Dangling Node trigger dead loop. (AppFlowy-IO#623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants