fix AppImageKit compilation by restoring appimage_get_elf_size()

[hchunhui]

Currently AppImageKit can not be compiled with the master branch of libappimage, the build script reports "undefined reference to appimage_get_elf_size()".

the runtime of AppImageKit can only be linked with libappimage_shared, but appimage_get_elf_size() is moved into libappimage since 4f22f90 . Restoring the function will fix the issue.

[azubieta]

@hchunhui thanks for the contribution, but I think that this fix should go in the AppImageKit repo instead. As we moved that function in a legacy header so it may be deorecated at some point.

@probonopd @TheAssassin may have some comments on this.

[hchunhui]

appimage_get_elf_size() can be replace by appimage_get_payload_offset() according to current implementation, but after the replacement we have to link to the whole C++ library instead of libappimage_shared (relatively small, written by C). As the function is used by runtime of AppImageKit, and we may want to keep runtime small, so it may be worth to restore it.

[probonopd]

Yes, we want runtime.c to be as small and lightweight as possible and no heavyweight C++ dependencies in runtime.c.

Once we had:
https://github.com/AppImage/AppImageKit/blob/d66acbafe8e17f82f19d644b09df45c4e0bcd284/elf.c

[lalten]

What's the state of this? Without this fixed it looks like AppImageKit can not use any libappimage after 4f22f90 from Jan 2019

[TheAssassin]

I think we should not duplicate code within here, but instead really just move this code to AppImageKit's repository for now. Thanks anyway!