Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Upgrade SDWebImage to latest #363

Closed
aliraza-noon opened this issue Jun 5, 2023 · 6 comments
Closed

[Feature]: Upgrade SDWebImage to latest #363

aliraza-noon opened this issue Jun 5, 2023 · 6 comments

Comments

@aliraza-noon
Copy link

aliraza-noon commented Jun 5, 2023

What problem are you facing?

SDWebImage has problem with gifs on ProMotion display

Workarounds

I am not aware of a workaround, there is solution available though for this

Ideal Solution

Use the latest version of SDWebImage

Other Information

SDWebImage/SDWebImage#3279

SDWebImage/SDWebImage#3280

@aliraza-noon
Copy link
Author

I labeled this as feature request, this in fact is bug which causing some trouble for our users on new apple devices.

@aliraza-noon
Copy link
Author

aliraza-noon commented Jun 5, 2023

I have raised a pr as well, I am not sure how helpful is that #364

@jerielng
Copy link
Collaborator

jerielng commented Jun 5, 2023

Hey @aliraza-noon, thanks for raising this issue and a corresponding pull request. Since you have forked the repository from your end, is it possible to use the forked version in your app as a workaround?

Our Objective-C Appboy iOS SDK is deprecated, and we recommend upgrading to our Swift SDK, which allows you to use Braze independently of an implicit dependency on SDWebImage. We also have a migration guide to ease this process.

@aliraza-noon
Copy link
Author

@jerielng thanks for replying, unfortunately using my forks is not possible for us

I did not see notice for deprecation anywhere, please help us with this as we have a dependency on this in one of our apps.

@jerielng
Copy link
Collaborator

jerielng commented Jun 6, 2023

Hi @aliraza-noon, are you using CocoaPods or SPM to integrate AppboyKit? In either case, the version dependencies for SDWebImage shouldn't limit you from upgrading to the latest version in your app.

For instance, in CocoaPods, we are using the syntax >= 5.8.2 in our podspec, you should be able to use any version greater than or equal to that by running pod update SDWebImage to get the latest version (5.16.0) in your project.

Likewise, for SPM integrations, you can right-click on SDWebImage under your Package Dependencies and then Update Package.

@hokstuff
Copy link
Collaborator

Closing out this issue based on the solution described above. Since the syntax for the podspec and the Package.swift describe the version floor, you are able to still update to the latest version of SDWebImage with today's Appboy iOS SDK code.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants