Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: Faint visual feedback for the contact on club card #140

Closed
zaclimon opened this issue Jun 3, 2021 · 1 comment · Fixed by #149
Closed

Dashboard: Faint visual feedback for the contact on club card #140

zaclimon opened this issue Jun 3, 2021 · 1 comment · Fixed by #149
Assignees
@AlexandreMarkus
Labels
bug Something isn't working feature: Dashboard Issue concerning the dashboard section of the application good first issue Good for newcomers platform: android platform: ios

Comments

@zaclimon
Copy link

zaclimon commented Jun 3, 2021 •
edited
Loading

Describe the bug
There's no way of knowing if the buttons on the club cards are buttons or not due to the lack of visual indication (Eg. ripples)

To Reproduce
Steps to reproduce the behavior:

  1. Go to Dashboard
  2. Try to select one of the way to reach the club (Facebook, GitHub, Email)

Expected behavior
A ripple should be shown that indicates that the user can at least understand that it is a flat button.

Screenshots
Screen record of both behavior in ÉTSMobile V3 and V4:

screen-20210603-164710.mp4

Smartphone (please complete the following information):

  • Device: Pixel 3a
  • OS: Android 11
  • Browser: Chrome Beta
  • Version: 91

Additional context
None
@zaclimon zaclimon added the bug Something isn't working label Jun 3, 2021
@apomalyn apomalyn added feature: Dashboard Issue concerning the dashboard section of the application platform: android platform: ios good first issue Good for newcomers labels Jun 3, 2021
@apomalyn
Copy link
Member

apomalyn commented Jun 3, 2021

For the person that will handle it: here we speak about the colour of the inksplash 😄

@AlexandreMarkus AlexandreMarkus self-assigned this Jun 6, 2021
This was referenced Jun 6, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexandreMarkus AlexandreMarkus

Labels
bug Something isn't working feature: Dashboard Issue concerning the dashboard section of the application good first issue Good for newcomers platform: android platform: ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added border to buttons ApplETS/Notre-Dame
3 participants
@zaclimon @apomalyn @AlexandreMarkus