Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Debugger) ECHO is limited to 55 chars #481

Open
TommyGH opened this issue Aug 25, 2017 · 6 comments
Open

(Debugger) ECHO is limited to 55 chars #481

TommyGH opened this issue Aug 25, 2017 · 6 comments

Comments

@TommyGH
Copy link

TommyGH commented Aug 25, 2017

Per Mike's request in #476, I'm creating another Issue.
Title says it all. Can only display 55 characters with ECHO command.

@Michaelangel007
Copy link
Contributor

Michaelangel007 commented Aug 25, 2017

Repro.:

  1. Start AppleWin
  2. F7
  3. echo " 23456789_123456789_123456789_123456789_123456789_123456789_123456789_123456789ABC"

@Michaelangel007
Copy link
Contributor

Michaelangel007 commented Aug 25, 2017

  • ParseInput() nArg = ArgsGet( pConsoleInput ); // Get the Raw Args
    • MAX_ARG_LEN = 56
    • 	g_aArgs[ iArg ] = g_aArgRaw[ iArg ];
      
  • CMD_OUTPUT_ECHO
  • CmdOutputEcho() in Debug.cpp
    • g_aArgs[1].nArgLen = 55, why?

@Michaelangel007
Copy link
Contributor

Bug not checking if iTokenSrc is TOKEN_QUOTE_DOUBLE

		if (nBuf > 0)
		{
			nLen = MIN( nBuf, MAX_ARG_LEN-1 );

@Michaelangel007
Copy link
Contributor

Michaelangel007 commented Aug 25, 2017

Q. Do we need to cap against CONSOLE_WIDTH ?
A. Yes ...

	struct Arg_t
	{	
		char       sArg[ MAX_ARG_LEN ]; // Array chars comes first, for alignment

Should be CONSOLE_WIDTH+2 (since width is 80) sigh but CONSOLE_WIDTH isn't defined at this point.

Resolution: Bump MAX_ARG_LEN to 128 127

@Michaelangel007
Copy link
Contributor

NOTE: Need to merge #480 before we can bump debugger version & update docs/Debugger_Changelog.txt

@Michaelangel007
Copy link
Contributor

sigh Need to spin off a new bug ... console input dropping chars

  • run output clipped to 61 chars
 23456789_123456789_123456789_123456789_123456789_123456789_1
  • echo output clipped to 59 chars
 23456789_123456789_123456789_123456789_123456789_123456789_123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants