Fixes #1905: Export bus now considers failed crafting requests #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng requests The export bus will now no longer speed up, if more than 1 of the last crafting requests failed and slow down, if more then 5 failed. Some code cleanup and moved the custom iterator into the helper package as it is clearly related to the craftingtracker and not the export bus.
|
SonarQube analysis reported 2 issues:
Watch the comments in this conversation to review them. |
| @@ -49,8 +49,9 @@ public boolean hasNext() | |||
| @Override | |||
| public E next() | |||
There was a problem hiding this comment.
Add a "NoSuchElementException" for iteration beyond the end of the collection. 
yueh
added a commit
that referenced
this pull request
Sep 26, 2015
Fixes #1905: Export bus now considers failed crafting requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The export bus will now no longer speed up, if more than 1 of the last
crafting requests failed and slow down, if more then 5 failed.
Some code cleanup and moved the custom iterator into the helper package
as it is clearly related to the craftingtracker and not the export bus.
Fixes #1905