Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Electron React Boilerplate #241

Closed
kamilzyla opened this issue Oct 21, 2021 · 2 comments · Fixed by #307
Closed

Update Electron React Boilerplate #241

kamilzyla opened this issue Oct 21, 2021 · 2 comments · Fixed by #307
Assignees
Labels
13 SP Story points tech debt Tasks that will make working on the project easier

Comments

@kamilzyla
Copy link
Collaborator

This is an idea to research along with #240. It might be time-effective to try to port our code to the newest version of the Electron React Boilerplate, which the app is based on. This has a chance to be simpler than trying to update all our packages one by one (as they might have multiple codependencies) and would offer additional benefits: better support due to using the latest version of the boilerplate, a chance to clean-up the project (we do have some dead code / unused crust).

@kamilzyla kamilzyla added the tech debt Tasks that will make working on the project easier label Oct 21, 2021
@kamilzyla kamilzyla added the 13 SP Story points label Jan 18, 2022
@kamilzyla kamilzyla self-assigned this Jul 4, 2022
@kamilzyla
Copy link
Collaborator Author

kamilzyla commented Jul 7, 2022

Getting all the dependencies right when migrating to the newest ERB is a challenge. Here's a list of our dependencies (as of d40e032) for reference.

Added to package.json by us

Prod

@blueprintjs/core
@redux-beacon/google-analytics
@redux-beacon/logger
@redux-beacon/offline-web
d3-dsv
date-fns
i18next
lodash
mapbox-gl
node-machine-id
react-i18next
react-select
redux-beacon
universal-analytics

Dev

@types/d3-dsv
@types/mapbox-gl
@types/universal-analytics

Imported without adding to package.json

Missing declaration

@blueprintjs/icons

Node.js

child_process
fs
path

Still good in latest ERB

electron
electron-log
electron-updater
react
react-dom
react-router-dom

Missing in latest ERB

connected-react-router
history
react-hot-loader
react-redux
react-router
redux
redux-logger
redux-thunk

@kamilzyla kamilzyla mentioned this issue Jul 11, 2022
@kamilzyla
Copy link
Collaborator Author

Update after #282:

Added to package.json by us

Prod

@blueprintjs/core
d3-dsv
date-fns
i18next
lodash
mapbox-gl
node-machine-id
react-i18next
react-select
universal-analytics

Dev

@types/d3-dsv
@types/mapbox-gl
@types/universal-analytics

Imported without adding to package.json

Missing declaration

@blueprintjs/icons

Node.js

child_process
fs
path

Still good in latest ERB

electron
electron-log
electron-updater
react
react-dom
react-router-dom

Missing in latest ERB

react-hot-loader
react-router

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13 SP Story points tech debt Tasks that will make working on the project easier
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant